Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2699533005: Fix IMFSample leak in DXVAVideoDecodeAccelerator (Closed)

Created:
3 years, 10 months ago by jbauman
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Fix IMFSample leak in DXVAVideoDecodeAccelerator Since r439662 DXVAVideoDecodeAccelerator has been adding an extra reference to the IMFSample, causing a leak. Switch more code to use ScopedComPtr to fix this. BUG=689678 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2693923003 Cr-Commit-Position: refs/heads/master@{#450218} (cherry picked from commit ab60729c01d4e123052aa4fecdf3752dc57bf9c2) Review-Url: https://codereview.chromium.org/2699533005 . Cr-Commit-Position: refs/branch-heads/2987@{#535} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/1ad1e31fe09edd48255871b00db7cd8298d9e7b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M media/base/win/mf_helpers.h View 2 chunks +3 lines, -4 lines 0 comments Download
M media/base/win/mf_helpers.cc View 3 chunks +11 lines, -6 lines 0 comments Download
M media/gpu/media_foundation_video_encode_accelerator_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jbauman
3 years, 10 months ago (2017-02-16 01:03:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1ad1e31fe09edd48255871b00db7cd8298d9e7b6 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698