Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2693923003: Fix IMFSample leak in DXVAVideoDecodeAccelerator (Closed)

Created:
3 years, 10 months ago by jbauman
Modified:
3 years, 10 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix IMFSample leak in DXVAVideoDecodeAccelerator Since r439662 DXVAVideoDecodeAccelerator has been adding an extra reference to the IMFSample, causing a leak. Switch more code to use ScopedComPtr to fix this. BUG=689678 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2693923003 Cr-Commit-Position: refs/heads/master@{#450218} Committed: https://chromium.googlesource.com/chromium/src/+/ab60729c01d4e123052aa4fecdf3752dc57bf9c2

Patch Set 1 #

Patch Set 2 : fix explicit initialization #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M media/base/win/mf_helpers.h View 2 chunks +3 lines, -4 lines 0 comments Download
M media/base/win/mf_helpers.cc View 1 3 chunks +11 lines, -6 lines 0 comments Download
M media/gpu/media_foundation_video_encode_accelerator_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
jbauman
3 years, 10 months ago (2017-02-14 00:41:16 UTC) #7
DaleCurtis
lgtm
3 years, 10 months ago (2017-02-14 00:43:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2693923003/20001
3 years, 10 months ago (2017-02-14 03:10:36 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 03:15:41 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ab60729c01d4e123052aa4fecdf3...

Powered by Google App Engine
This is Rietveld 408576698