Reland of Android: Use linker script to hide all non-JNI symbols

Reland of Android: Use linker script to hide all non-JNI symbols

The linker script is applied to all shared_library() targets by default,
just like the hide_jni one was (but not loadable_module() targets).

This reduces the size of libchrome.so by 220kb.

Reverted in:
https://codereview.chromium.org/2685933002/

Reason for reland:
Tested webkit_tests now pass locally. Issue was that libosmesa.so
had its symbols hidden.

BUG=448386
TBR=brettw

Review-Url: https://codereview.chromium.org/2699473002
Cr-Commit-Position: refs/heads/master@{#450734}
Committed: https://chromium.googlesource.com/chromium/src/+/e61084f2f942e6203a98bb4f7e505f9d7b679604

[agrieve, 2017-02-14 20:29:54]

Created Reland of Android: Use linker script to hide all non-JNI symbols

[agrieve, 2017-02-14 21:36:41]

Description was changed from

==========
Reland of Android: Use linker script to hide all non-JNI symbols (patchset #1
id:1 of https://codereview.chromium.org/2685933002/ )

Reason for revert:
Will update this description once I figure out the fix.

Original issue's description:
> Revert of Android: Use linker script to hide all non-JNI symbols (patchset #4
id:60001 of https://codereview.chromium.org/2633593004/ )
> 
> Reason for revert:
> Speculative revert, potential culprit for webkit_tests crashing on "WebKit
Android (Nexus4)". 
> 
> Stack traces show not much else than JNI managed->native transitions and
syscalls.
> 
> Original issue's description:
> > Android: Use linker script to hide all non-JNI symbols
> > 
> > The linker script is applied to all shared_library() targets by default,
> > just like the hide_jni one was.
> > 
> > This reduces the size of libchrome.so by 220kb.
> > 
> > BUG=448386
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
> > 
> > Review-Url: https://codereview.chromium.org/2633593004
> > Cr-Commit-Position: refs/heads/master@{#448988}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/6888d5002b2eabe4fac226f0e512...
> 
>
TBR=torne@chromium.org,digit@chromium.org,brettw@chromium.org,agrieve@chromiu...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=448386
> 
> Review-Url: https://codereview.chromium.org/2685933002
> Cr-Commit-Position: refs/heads/master@{#449028}
> Committed:
https://chromium.googlesource.com/chromium/src/+/de69a7c823b439d35e7ee716a1da...

TBR=torne@chromium.org,digit@chromium.org,brettw@chromium.org,engedy@chromium...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=448386
==========

to

==========
Reland of Android: Use linker script to hide all non-JNI symbols

The linker script is applied to all shared_library() targets by default,
just like the hide_jni one was (but not loadable_module() targets).

This reduces the size of libchrome.so by 220kb.

Reverted in:
https://codereview.chromium.org/2685933002/

Reason for reland:
Tested webkit_tests now pass locally. Issue was that libosmesa.so
had its symbols hidden.

BUG=448386
==========

[agrieve, 2017-02-14 21:37:03]

Description was changed from

==========
Reland of Android: Use linker script to hide all non-JNI symbols

The linker script is applied to all shared_library() targets by default,
just like the hide_jni one was (but not loadable_module() targets).

This reduces the size of libchrome.so by 220kb.

Reverted in:
https://codereview.chromium.org/2685933002/

Reason for reland:
Tested webkit_tests now pass locally. Issue was that libosmesa.so
had its symbols hidden.

BUG=448386
==========

to

==========
Reland of Android: Use linker script to hide all non-JNI symbols (patchset #1
id:1 of https://codereview.chromium.org/2685933002/ )

Reason for revert:
Will update this description once I figure out the fix.

Original issue's description:
> Revert of Android: Use linker script to hide all non-JNI symbols (patchset #4
id:60001 of https://codereview.chromium.org/2633593004/ )
> 
> Reason for revert:
> Speculative revert, potential culprit for webkit_tests crashing on "WebKit
Android (Nexus4)". 
> 
> Stack traces show not much else than JNI managed->native transitions and
syscalls.
> 
> Original issue's description:
> > Android: Use linker script to hide all non-JNI symbols
> > 
> > The linker script is applied to all shared_library() targets by default,
> > just like the hide_jni one was.
> > 
> > This reduces the size of libchrome.so by 220kb.
> > 
> > BUG=448386
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
> > 
> > Review-Url: https://codereview.chromium.org/2633593004
> > Cr-Commit-Position: refs/heads/master@{#448988}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/6888d5002b2eabe4fac226f0e512...
> 
>
TBR=torne@chromium.org,digit@chromium.org,brettw@chromium.org,agrieve@chromiu...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=448386
> 
> Review-Url: https://codereview.chromium.org/2685933002
> Cr-Commit-Position: refs/heads/master@{#449028}
> Committed:
https://chromium.googlesource.com/chromium/src/+/de69a7c823b439d35e7ee716a1da...

TBR=torne@chromium.org,digit@chromium.org,brettw@chromium.org,engedy@chromium...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=448386
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[agrieve, 2017-02-14 21:37:04]

Description was changed from

==========
Reland of Android: Use linker script to hide all non-JNI symbols (patchset #1
id:1 of https://codereview.chromium.org/2685933002/ )

Reason for revert:
Will update this description once I figure out the fix.

Original issue's description:
> Revert of Android: Use linker script to hide all non-JNI symbols (patchset #4
id:60001 of https://codereview.chromium.org/2633593004/ )
> 
> Reason for revert:
> Speculative revert, potential culprit for webkit_tests crashing on "WebKit
Android (Nexus4)". 
> 
> Stack traces show not much else than JNI managed->native transitions and
syscalls.
> 
> Original issue's description:
> > Android: Use linker script to hide all non-JNI symbols
> > 
> > The linker script is applied to all shared_library() targets by default,
> > just like the hide_jni one was.
> > 
> > This reduces the size of libchrome.so by 220kb.
> > 
> > BUG=448386
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
> > 
> > Review-Url: https://codereview.chromium.org/2633593004
> > Cr-Commit-Position: refs/heads/master@{#448988}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/6888d5002b2eabe4fac226f0e512...
> 
>
TBR=torne@chromium.org,digit@chromium.org,brettw@chromium.org,agrieve@chromiu...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=448386
> 
> Review-Url: https://codereview.chromium.org/2685933002
> Cr-Commit-Position: refs/heads/master@{#449028}
> Committed:
https://chromium.googlesource.com/chromium/src/+/de69a7c823b439d35e7ee716a1da...

TBR=torne@chromium.org,digit@chromium.org,brettw@chromium.org,engedy@chromium...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=448386
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Reland of Android: Use linker script to hide all non-JNI symbols (patchset #1
id:1 of https://codereview.chromium.org/2685933002/ )

Reason for revert:
Will update this description once I figure out the fix.

Original issue's description:
> Revert of Android: Use linker script to hide all non-JNI symbols (patchset #4
id:60001 of https://codereview.chromium.org/2633593004/ )
> 
> Reason for revert:
> Speculative revert, potential culprit for webkit_tests crashing on "WebKit
Android (Nexus4)". 
> 
> Stack traces show not much else than JNI managed->native transitions and
syscalls.
> 
> Original issue's description:
> > Android: Use linker script to hide all non-JNI symbols
> > 
> > The linker script is applied to all shared_library() targets by default,
> > just like the hide_jni one was.
> > 
> > This reduces the size of libchrome.so by 220kb.
> > 
> > BUG=448386
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
> > 
> > Review-Url: https://codereview.chromium.org/2633593004
> > Cr-Commit-Position: refs/heads/master@{#448988}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/6888d5002b2eabe4fac226f0e512...
> 
>
TBR=torne@chromium.org,digit@chromium.org,brettw@chromium.org,agrieve@chromiu...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=448386
> 
> Review-Url: https://codereview.chromium.org/2685933002
> Cr-Commit-Position: refs/heads/master@{#449028}
> Committed:
https://chromium.googlesource.com/chromium/src/+/de69a7c823b439d35e7ee716a1da...

TBR=torne@chromium.org,digit@chromium.org,brettw@chromium.org,engedy@chromium...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=448386
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[agrieve, 2017-02-14 21:37:31]

Description was changed from

==========
Reland of Android: Use linker script to hide all non-JNI symbols (patchset #1
id:1 of https://codereview.chromium.org/2685933002/ )

Reason for revert:
Will update this description once I figure out the fix.

Original issue's description:
> Revert of Android: Use linker script to hide all non-JNI symbols (patchset #4
id:60001 of https://codereview.chromium.org/2633593004/ )
> 
> Reason for revert:
> Speculative revert, potential culprit for webkit_tests crashing on "WebKit
Android (Nexus4)". 
> 
> Stack traces show not much else than JNI managed->native transitions and
syscalls.
> 
> Original issue's description:
> > Android: Use linker script to hide all non-JNI symbols
> > 
> > The linker script is applied to all shared_library() targets by default,
> > just like the hide_jni one was.
> > 
> > This reduces the size of libchrome.so by 220kb.
> > 
> > BUG=448386
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
> > 
> > Review-Url: https://codereview.chromium.org/2633593004
> > Cr-Commit-Position: refs/heads/master@{#448988}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/6888d5002b2eabe4fac226f0e512...
> 
>
TBR=torne@chromium.org,digit@chromium.org,brettw@chromium.org,agrieve@chromiu...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=448386
> 
> Review-Url: https://codereview.chromium.org/2685933002
> Cr-Commit-Position: refs/heads/master@{#449028}
> Committed:
https://chromium.googlesource.com/chromium/src/+/de69a7c823b439d35e7ee716a1da...

TBR=torne@chromium.org,digit@chromium.org,brettw@chromium.org,engedy@chromium...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=448386
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Reland of Android: Use linker script to hide all non-JNI symbols

The linker script is applied to all shared_library() targets by default,
just like the hide_jni one was (but not loadable_module() targets).

This reduces the size of libchrome.so by 220kb.

Reverted in:
https://codereview.chromium.org/2685933002/

Reason for reland:
Tested webkit_tests now pass locally. Issue was that libosmesa.so
had its symbols hidden.

BUG=448386
==========

[agrieve, 2017-02-14 21:38:29]

On 2017/02/14 20:29:54, agrieve wrote:
> Created Reland of Android: Use linker script to hide all non-JNI symbols

Only change from PS1 is removing the config for loadable_module defaults.
Plan to reland tomorrow morning EST.

[agrieve, 2017-02-14 21:38:35]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 21:39:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 23:24:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 23:24:30]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Torne, 2017-02-15 11:10:21]

LGTM, seems reasonable

[agrieve, 2017-02-15 16:39:40]

Description was changed from

==========
Reland of Android: Use linker script to hide all non-JNI symbols

The linker script is applied to all shared_library() targets by default,
just like the hide_jni one was (but not loadable_module() targets).

This reduces the size of libchrome.so by 220kb.

Reverted in:
https://codereview.chromium.org/2685933002/

Reason for reland:
Tested webkit_tests now pass locally. Issue was that libosmesa.so
had its symbols hidden.

BUG=448386
==========

to

==========
Reland of Android: Use linker script to hide all non-JNI symbols

The linker script is applied to all shared_library() targets by default,
just like the hide_jni one was (but not loadable_module() targets).

This reduces the size of libchrome.so by 220kb.

Reverted in:
https://codereview.chromium.org/2685933002/

Reason for reland:
Tested webkit_tests now pass locally. Issue was that libosmesa.so
had its symbols hidden.

BUG=448386
TBR=brettw
==========

[agrieve, 2017-02-15 16:39:47]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2017-02-15 16:40:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 17:21:01]

CQ is committing da patch.

Bot data: {"patchset_id": 230001, "attempt_start_ts": 1487176787405710,
"parent_rev": "42f2438c1a1992481959a592d9e6391a0aac69b6", "commit_rev":
"e61084f2f942e6203a98bb4f7e505f9d7b679604"}

[commit-bot: I haz the power, 2017-02-15 17:21:39]

Description was changed from

==========
Reland of Android: Use linker script to hide all non-JNI symbols

The linker script is applied to all shared_library() targets by default,
just like the hide_jni one was (but not loadable_module() targets).

This reduces the size of libchrome.so by 220kb.

Reverted in:
https://codereview.chromium.org/2685933002/

Reason for reland:
Tested webkit_tests now pass locally. Issue was that libosmesa.so
had its symbols hidden.

BUG=448386
TBR=brettw
==========

to

==========
Reland of Android: Use linker script to hide all non-JNI symbols

The linker script is applied to all shared_library() targets by default,
just like the hide_jni one was (but not loadable_module() targets).

This reduces the size of libchrome.so by 220kb.

Reverted in:
https://codereview.chromium.org/2685933002/

Reason for reland:
Tested webkit_tests now pass locally. Issue was that libosmesa.so
had its symbols hidden.

BUG=448386
TBR=brettw

Review-Url: https://codereview.chromium.org/2699473002
Cr-Commit-Position: refs/heads/master@{#450734}
Committed:
https://chromium.googlesource.com/chromium/src/+/e61084f2f942e6203a98bb4f7e50...
==========

[commit-bot: I haz the power, 2017-02-15 17:21:41]

Committed patchset #2 (id:230001) as
https://chromium.googlesource.com/chromium/src/+/e61084f2f942e6203a98bb4f7e50...