Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: components/cronet/android/BUILD.gn

Issue 2699473002: Reland of Android: Use linker script to hide all non-JNI symbols (Closed)
Patch Set: fix loadable_module Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/BUILD.gn ('k') | components/cronet/android/only_jni_exports.lst » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/BUILD.gn
diff --git a/components/cronet/android/BUILD.gn b/components/cronet/android/BUILD.gn
index 91bbf4b2c8be5b37f9c04281ac8487373afccaa8..a6b7b5237b2fa6d15b257959f3ffdace019ea155 100644
--- a/components/cronet/android/BUILD.gn
+++ b/components/cronet/android/BUILD.gn
@@ -264,13 +264,6 @@ shared_library("cronet") {
"//base",
"//net:net",
]
- ldflags = [ "-Wl,--version-script=" +
- rebase_path("//components/cronet/android/only_jni_exports.lst") ]
-
- # Avoid hide_native_jni_exports as it adds another version script, and the
- # ARM64 linker throws an error for multiple version scripts with anonymous
- # version tags.
- configs -= [ "//build/config/android:hide_native_jni_exports" ]
}
cronet_api_srcjar_deps = [ ":cronet_api_version_srcjar" ]
@@ -552,14 +545,6 @@ shared_library("cronet_tests") {
include_dirs = [ _cronet_version_header_include_dir ]
- ldflags = [ "-Wl,--version-script=" +
- rebase_path("//components/cronet/android/only_jni_exports.lst") ]
-
- # Avoid hide_native_jni_exports as it adds another version script, and the
- # ARM64 linker throws an error for multiple version scripts with anonymous
- # version tags.
- configs -= [ "//build/config/android:hide_native_jni_exports" ]
-
if (cronet_enable_data_reduction_proxy_support) {
deps += [ "//components/data_reduction_proxy/core/browser:browser_small" ]
}
« no previous file with comments | « chrome/android/BUILD.gn ('k') | components/cronet/android/only_jni_exports.lst » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698