Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2699463002: Merge M57: "Always return CHANNEL_LAYOUT_UNSUPPORTED for unsupported layouts." (Closed)

Created:
3 years, 10 months ago by DaleCurtis
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Merge M57: "Always return CHANNEL_LAYOUT_UNSUPPORTED for unsupported layouts." The old code would sometimes return CHANNEL_LAYOUT_NONE which we don't handle fallback to guessing the layout for. Instead always return CHANNEL_LAYOUT_UNSUPPORTED so that we will properly attempt to guess the channel layout based on channel count. This is a speculative fix for broken audio on Traktor 2 Audio. BUG=651172 TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2687873006 Cr-Commit-Position: refs/heads/master@{#449831} (cherry picked from commit f062c42d082ebf9c2f2e39ac6683f7755d232ac2) Review-Url: https://codereview.chromium.org/2699463002 . Cr-Commit-Position: refs/branch-heads/2987@{#505} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/d37b8a11a391cc19ff7f9caac521fc1408d73218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M media/audio/win/core_audio_util_win.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
DaleCurtis
3 years, 10 months ago (2017-02-14 19:50:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d37b8a11a391cc19ff7f9caac521fc1408d73218 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698