Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 2687873006: Always return CHANNEL_LAYOUT_UNSUPPORTED for unsupported layouts. (Closed)

Created:
3 years, 10 months ago by DaleCurtis
Modified:
3 years, 10 months ago
Reviewers:
chcunningham
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always return CHANNEL_LAYOUT_UNSUPPORTED for unsupported layouts. The old code would sometimes return CHANNEL_LAYOUT_NONE which we don't handle fallback to guessing the layout for. Instead always return CHANNEL_LAYOUT_UNSUPPORTED so that we will properly attempt to guess the channel layout based on channel count. This is a speculative fix for broken audio on Traktor 2 Audio. BUG=651172 TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2687873006 Cr-Commit-Position: refs/heads/master@{#449831} Committed: https://chromium.googlesource.com/chromium/src/+/f062c42d082ebf9c2f2e39ac6683f7755d232ac2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M media/audio/win/core_audio_util_win.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
DaleCurtis
3 years, 10 months ago (2017-02-10 23:58:15 UTC) #3
chcunningham
LGTM
3 years, 10 months ago (2017-02-11 00:31:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687873006/1
3 years, 10 months ago (2017-02-11 00:32:34 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-11 02:10:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f062c42d082ebf9c2f2e39ac6683...

Powered by Google App Engine
This is Rietveld 408576698