Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2699393003: Cleanup ContentSuggestions, removing unused functions (Closed)

Created:
3 years, 10 months ago by gambard
Modified:
3 years, 10 months ago
Reviewers:
Olivier
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup ContentSuggestions, removing unused functions Rename ContentSuggestionsItem to ContentSuggestionsTextItem and remove the addEmptyItem method as it is unused. BUG=694159 Review-Url: https://codereview.chromium.org/2699393003 Cr-Commit-Position: refs/heads/master@{#451736} Committed: https://chromium.googlesource.com/chromium/src/+/75308d89e602764154da191eb0cb065c352cdd93

Patch Set 1 #

Patch Set 2 : Rename cell #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -284 lines) Patch
M ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/content_suggestions/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.h View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm View 1 2 2 chunks +1 line, -37 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/content_suggestions_item.h View 1 chunk +0 lines, -31 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/content_suggestions_item.mm View 1 chunk +0 lines, -97 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/content_suggestions_item_actions.h View 1 chunk +0 lines, -18 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/content_suggestions_item_unittest.mm View 1 chunk +0 lines, -31 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_text_item.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_text_item.mm View 1 6 chunks +9 lines, -9 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_text_item_actions.h View 1 chunk +5 lines, -5 lines 0 comments Download
A + ios/chrome/browser/ui/content_suggestions/content_suggestions_text_item_unittest.mm View 1 2 chunks +8 lines, -8 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm View 1 2 3 chunks +2 lines, -19 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
gambard
PTAL.
3 years, 10 months ago (2017-02-20 10:04:44 UTC) #2
Olivier
lgtm
3 years, 10 months ago (2017-02-20 16:42:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699393003/20001
3 years, 10 months ago (2017-02-20 16:43:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xcode-clang/builds/45921)
3 years, 10 months ago (2017-02-20 16:45:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699393003/40001
3 years, 10 months ago (2017-02-21 08:44:08 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/122984)
3 years, 10 months ago (2017-02-21 10:04:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699393003/40001
3 years, 10 months ago (2017-02-21 10:36:47 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 11:59:15 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/75308d89e602764154da191eb0cb...

Powered by Google App Engine
This is Rietveld 408576698