Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm

Issue 2699393003: Cleanup ContentSuggestions, removing unused functions (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
diff --git a/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm b/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
index 6e2c9a374327468ed7525c3cf60551133f5886b5..22af1015593dde7730a51d2317ac4693cfc54aa6 100644
--- a/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
+++ b/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
@@ -14,9 +14,9 @@
#import "ios/chrome/browser/ui/content_suggestions/content_suggestions_data_source.h"
#import "ios/chrome/browser/ui/content_suggestions/content_suggestions_expandable_item.h"
#import "ios/chrome/browser/ui/content_suggestions/content_suggestions_favicon_item.h"
-#import "ios/chrome/browser/ui/content_suggestions/content_suggestions_item.h"
#import "ios/chrome/browser/ui/content_suggestions/content_suggestions_section_information.h"
#import "ios/chrome/browser/ui/content_suggestions/content_suggestions_stack_item.h"
+#import "ios/chrome/browser/ui/content_suggestions/content_suggestions_text_item.h"
#import "ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h"
#include "url/gurl.h"
@@ -125,42 +125,6 @@ SectionIdentifier SectionIdentifierForInfo(
#pragma mark - Public methods
-- (void)addTextItem:(NSString*)title
- subtitle:(NSString*)subtitle
- toSection:(NSInteger)inputSection {
- DCHECK(self.collectionViewController);
- ContentSuggestionsItem* item =
- [[ContentSuggestionsItem alloc] initWithType:ItemTypeText
- title:title
- subtitle:subtitle];
- NSInteger sectionIdentifier = kSectionIdentifierEnumZero + inputSection;
- NSInteger sectionIndex = inputSection;
- CollectionViewModel* model =
- self.collectionViewController.collectionViewModel;
- if ([model numberOfSections] <= inputSection) {
- sectionIndex = [model numberOfSections];
- sectionIdentifier = kSectionIdentifierEnumZero + sectionIndex;
- [self.collectionViewController.collectionView performBatchUpdates:^{
- [self.collectionViewController.collectionViewModel
- addSectionWithIdentifier:sectionIdentifier];
- [self.collectionViewController.collectionView
- insertSections:[NSIndexSet indexSetWithIndex:sectionIndex]];
- }
- completion:nil];
- }
- NSInteger numberOfItemsInSection =
- [model numberOfItemsInSection:sectionIndex];
- [self.collectionViewController.collectionViewModel addItem:item
- toSectionWithIdentifier:sectionIdentifier];
- [self.collectionViewController.collectionView performBatchUpdates:^{
- [self.collectionViewController.collectionView
- insertItemsAtIndexPaths:@[ [NSIndexPath
- indexPathForRow:numberOfItemsInSection
- inSection:sectionIndex] ]];
- }
- completion:nil];
-}
-
- (BOOL)shouldUseCustomStyleForSection:(NSInteger)section {
NSNumber* identifier = @([self.collectionViewController.collectionViewModel
sectionIdentifierForSection:section]);

Powered by Google App Engine
This is Rietveld 408576698