Register APM even though echo cancellation is disabled.

Register APM even though echo cancellation is disabled.

When playout data passes through WebRTCAudioDeviceImpl, it's passed to
the playout sinks. As of crrev.com/e3af3e, only
MediaStreamAudioProcessor implements the sink interface. In the sink
callback function (MediaStreamAudioProcessor::OnPlayoutData), the
playout data is passed to the webrtc AudioProcessing module.

The AudioProcessor registers itself as a sink in AudioDeviceImpl in
::InitializeAudioProcessingModule, but only when
audio_constraints.GetEchoCancellationProperty() = false. This has
consequences for crbug.com/webrtc/7169 (no AEC dump recording with
echo cancellation off) and crbug.com/696955 (echo detector reports
zeroes with echo cancellation off).

This CL makes the MediaStreamAudioProcessor register itself as a sink
indepedentent of audio_constraints.GetEchoCancellationProperty().


BUG=webrtc:7169, 696955
Review-Url: https://codereview.chromium.org/2699113002
Cr-Commit-Position: refs/heads/master@{#456677}
Committed: https://chromium.googlesource.com/chromium/src/+/9d9f3e8b0d895e5c1f3f47078b5f729cbae5738b

[aleloi_chromium, 2017-02-17 11:03:07]

The CQ bit was checked by aleloi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 11:03:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 12:15:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 12:15:06]

Dry run: This issue passed the CQ dry run.

[aleloi_chromium, 2017-03-14 09:03:35]

The CQ bit was checked by aleloi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 09:03:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleloi_chromium, 2017-03-14 09:36:57]

Description was changed from

==========
Register APM even though echo cancellation is disabled.

TODO: Detailed description.

BUG=webrtc:7169
==========

to

==========
Register APM even though echo cancellation is disabled.

When playout data passes through WebRTCAudioDeviceImpl, it's passed to
the playout sinks. As of crrev.com/e3af3e, only
MediaStreamAudioProcessor implements the sink interface. In the sink
callback function (MediaStreamAudioProcessor::OnPlayoutData), the
playout data is passed to the webrtc AudioProcessing module.

The AudioProcessor registers itself as a sink in AudioDeviceImpl in
::InitializeAudioProcessingModule, but only when
audio_constraints.GetEchoCancellationProperty() = false. This has
consequences for crbug.com/webrtc/7169 (no AEC dump recording with
echo cancellation off) and crbug.com/696955 (echo detector reports
zeroes with echo cancellation off).

This CL makes the MediaStreamAudioProcessor register itself as a sink
indepedentent of audio_constraints.GetEchoCancellationProperty().


BUG=webrtc:7169 696955
==========

[aleloi_chromium, 2017-03-14 09:37:15]

Description was changed from

==========
Register APM even though echo cancellation is disabled.

When playout data passes through WebRTCAudioDeviceImpl, it's passed to
the playout sinks. As of crrev.com/e3af3e, only
MediaStreamAudioProcessor implements the sink interface. In the sink
callback function (MediaStreamAudioProcessor::OnPlayoutData), the
playout data is passed to the webrtc AudioProcessing module.

The AudioProcessor registers itself as a sink in AudioDeviceImpl in
::InitializeAudioProcessingModule, but only when
audio_constraints.GetEchoCancellationProperty() = false. This has
consequences for crbug.com/webrtc/7169 (no AEC dump recording with
echo cancellation off) and crbug.com/696955 (echo detector reports
zeroes with echo cancellation off).

This CL makes the MediaStreamAudioProcessor register itself as a sink
indepedentent of audio_constraints.GetEchoCancellationProperty().


BUG=webrtc:7169 696955
==========

to

==========
Register APM even though echo cancellation is disabled.

When playout data passes through WebRTCAudioDeviceImpl, it's passed to
the playout sinks. As of crrev.com/e3af3e, only
MediaStreamAudioProcessor implements the sink interface. In the sink
callback function (MediaStreamAudioProcessor::OnPlayoutData), the
playout data is passed to the webrtc AudioProcessing module.

The AudioProcessor registers itself as a sink in AudioDeviceImpl in
::InitializeAudioProcessingModule, but only when
audio_constraints.GetEchoCancellationProperty() = false. This has
consequences for crbug.com/webrtc/7169 (no AEC dump recording with
echo cancellation off) and crbug.com/696955 (echo detector reports
zeroes with echo cancellation off).

This CL makes the MediaStreamAudioProcessor register itself as a sink
indepedentent of audio_constraints.GetEchoCancellationProperty().


BUG=webrtc:7169, 696955
==========

[aleloi_chromium, 2017-03-14 09:39:54]

aleloi@chromium.org changed reviewers:
+ hbos@chromium.org

[aleloi_chromium, 2017-03-14 09:39:54]

PTAL!

[commit-bot: I haz the power, 2017-03-14 09:49:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 09:49:04]

Dry run: This issue passed the CQ dry run.

[hbos_chromium, 2017-03-14 12:01:25]

lgtm

[aleloi_chromium, 2017-03-14 12:33:26]

The CQ bit was checked by aleloi@chromium.org

[commit-bot: I haz the power, 2017-03-14 12:33:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 12:37:44]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489494806705680, "parent_rev":
"d063e7b60234643283d735f7176eb8a323d61431", "commit_rev":
"9d9f3e8b0d895e5c1f3f47078b5f729cbae5738b"}

[commit-bot: I haz the power, 2017-03-14 12:38:30]

Description was changed from

==========
Register APM even though echo cancellation is disabled.

When playout data passes through WebRTCAudioDeviceImpl, it's passed to
the playout sinks. As of crrev.com/e3af3e, only
MediaStreamAudioProcessor implements the sink interface. In the sink
callback function (MediaStreamAudioProcessor::OnPlayoutData), the
playout data is passed to the webrtc AudioProcessing module.

The AudioProcessor registers itself as a sink in AudioDeviceImpl in
::InitializeAudioProcessingModule, but only when
audio_constraints.GetEchoCancellationProperty() = false. This has
consequences for crbug.com/webrtc/7169 (no AEC dump recording with
echo cancellation off) and crbug.com/696955 (echo detector reports
zeroes with echo cancellation off).

This CL makes the MediaStreamAudioProcessor register itself as a sink
indepedentent of audio_constraints.GetEchoCancellationProperty().


BUG=webrtc:7169, 696955
==========

to

==========
Register APM even though echo cancellation is disabled.

When playout data passes through WebRTCAudioDeviceImpl, it's passed to
the playout sinks. As of crrev.com/e3af3e, only
MediaStreamAudioProcessor implements the sink interface. In the sink
callback function (MediaStreamAudioProcessor::OnPlayoutData), the
playout data is passed to the webrtc AudioProcessing module.

The AudioProcessor registers itself as a sink in AudioDeviceImpl in
::InitializeAudioProcessingModule, but only when
audio_constraints.GetEchoCancellationProperty() = false. This has
consequences for crbug.com/webrtc/7169 (no AEC dump recording with
echo cancellation off) and crbug.com/696955 (echo detector reports
zeroes with echo cancellation off).

This CL makes the MediaStreamAudioProcessor register itself as a sink
indepedentent of audio_constraints.GetEchoCancellationProperty().


BUG=webrtc:7169, 696955

Review-Url: https://codereview.chromium.org/2699113002
Cr-Commit-Position: refs/heads/master@{#456677}
Committed:
https://chromium.googlesource.com/chromium/src/+/9d9f3e8b0d895e5c1f3f47078b5f...
==========

[commit-bot: I haz the power, 2017-03-14 12:38:31]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9d9f3e8b0d895e5c1f3f47078b5f...