DescriptionRegister APM even though echo cancellation is disabled.
When playout data passes through WebRTCAudioDeviceImpl, it's passed to
the playout sinks. As of crrev.com/e3af3e, only
MediaStreamAudioProcessor implements the sink interface. In the sink
callback function (MediaStreamAudioProcessor::OnPlayoutData), the
playout data is passed to the webrtc AudioProcessing module.
The AudioProcessor registers itself as a sink in AudioDeviceImpl in
::InitializeAudioProcessingModule, but only when
audio_constraints.GetEchoCancellationProperty() = false. This has
consequences for crbug.com/webrtc/7169 (no AEC dump recording with
echo cancellation off) and crbug.com/696955 (echo detector reports
zeroes with echo cancellation off).
This CL makes the MediaStreamAudioProcessor register itself as a sink
indepedentent of audio_constraints.GetEchoCancellationProperty().
BUG=webrtc:7169, 696955
Review-Url: https://codereview.chromium.org/2699113002
Cr-Commit-Position: refs/heads/master@{#456677}
Committed: https://chromium.googlesource.com/chromium/src/+/9d9f3e8b0d895e5c1f3f47078b5f729cbae5738b
Patch Set 1 #
Messages
Total messages: 18 (14 generated)
|