Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: tools/grit/grit_rule.gni

Issue 2698913007: Provide startup resource numbering files for Mac and Windows. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/grit/grit_rule.gni
diff --git a/tools/grit/grit_rule.gni b/tools/grit/grit_rule.gni
index eab19564c1f2da85397b17c93305660e768585c0..262935fd3c2192eba83b5046cb0faf88aa043ee2 100644
--- a/tools/grit/grit_rule.gni
+++ b/tools/grit/grit_rule.gni
@@ -250,9 +250,14 @@ grit_resource_id_file = "//tools/gritsettings/resource_ids"
grit_info_script = "//tools/grit/grit_info.py"
grit_predetermined_resource_ids_file = ""
-
-# TODO(asvitkine): Add platform-specific resource id file paths here.
-# http://crbug.com/692670
+if (is_mac) {
+ grit_predetermined_resource_ids_file =
+ "//tools/gritsettings/startup_resources_mac.txt"
+}
+if (is_win) {
+ grit_predetermined_resource_ids_file =
+ "//tools/gritsettings/startup_resources_win.txt"
+}
Nico 2017/02/17 21:51:13 TODO for linux, android, chromeos, ios?
Alexei Svitkine (slow) 2017/02/17 22:11:17 Done.
template("grit") {
assert(defined(invoker.source),
« no previous file with comments | « no previous file | tools/gritsettings/startup_resources_mac.txt » ('j') | tools/gritsettings/startup_resources_win.txt » ('J')

Powered by Google App Engine
This is Rietveld 408576698