Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: tools/grit/grit_rule.gni

Issue 2698913007: Provide startup resource numbering files for Mac and Windows. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Instantiate grit. This will produce a script target to run grit, and a 5 # Instantiate grit. This will produce a script target to run grit, and a
6 # static library that compiles the .cc files. 6 # static library that compiles the .cc files.
7 # 7 #
8 # Parameters 8 # Parameters
9 # 9 #
10 # source (required) 10 # source (required)
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 243
244 # TODO(aberent): Enable for other platforms once the build machines have 244 # TODO(aberent): Enable for other platforms once the build machines have
245 # Java on them (and hence can run the closure compiler). 245 # Java on them (and hence can run the closure compiler).
246 _strip_resource_files = is_android 246 _strip_resource_files = is_android
247 _js_minifier = "//third_party/closure_compiler/js_minify.py" 247 _js_minifier = "//third_party/closure_compiler/js_minify.py"
248 248
249 grit_resource_id_file = "//tools/gritsettings/resource_ids" 249 grit_resource_id_file = "//tools/gritsettings/resource_ids"
250 grit_info_script = "//tools/grit/grit_info.py" 250 grit_info_script = "//tools/grit/grit_info.py"
251 251
252 grit_predetermined_resource_ids_file = "" 252 grit_predetermined_resource_ids_file = ""
253 253 if (is_mac) {
254 # TODO(asvitkine): Add platform-specific resource id file paths here. 254 grit_predetermined_resource_ids_file =
255 # http://crbug.com/692670 255 "//tools/gritsettings/startup_resources_mac.txt"
256 }
257 if (is_win) {
258 grit_predetermined_resource_ids_file =
259 "//tools/gritsettings/startup_resources_win.txt"
260 }
Nico 2017/02/17 21:51:13 TODO for linux, android, chromeos, ios?
Alexei Svitkine (slow) 2017/02/17 22:11:17 Done.
256 261
257 template("grit") { 262 template("grit") {
258 assert(defined(invoker.source), 263 assert(defined(invoker.source),
259 "\"source\" must be defined for the grit template $target_name") 264 "\"source\" must be defined for the grit template $target_name")
260 265
261 if (defined(invoker.resource_ids)) { 266 if (defined(invoker.resource_ids)) {
262 resource_ids = invoker.resource_ids 267 resource_ids = invoker.resource_ids
263 } else { 268 } else {
264 resource_ids = grit_resource_id_file 269 resource_ids = grit_resource_id_file
265 } 270 }
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
483 if (defined(invoker.configs)) { 488 if (defined(invoker.configs)) {
484 configs += invoker.configs 489 configs += invoker.configs
485 } 490 }
486 491
487 if (defined(invoker.visibility)) { 492 if (defined(invoker.visibility)) {
488 visibility = invoker.visibility 493 visibility = invoker.visibility
489 } 494 }
490 output_name = grit_output_name 495 output_name = grit_output_name
491 } 496 }
492 } 497 }
OLDNEW
« no previous file with comments | « no previous file | tools/gritsettings/startup_resources_mac.txt » ('j') | tools/gritsettings/startup_resources_win.txt » ('J')

Powered by Google App Engine
This is Rietveld 408576698