Provide startup resource numbering files for Mac and Windows.

Provide startup resource numbering files for Mac and Windows.

The resources in these files will be assigned the specified ids so that
they're packed in the order that they're expected to be loaded on startup.

This should reduce page faults incurred on start up and improve startup
performance - especially on systems where I/O is slow.

This uses the mechanism added in the following CL to do the renumbering:
https://codereview.chromium.org/2690263004/

These files were generated using the script and README.md
instructions being added in:
  https://codereview.chromium.org/2696303003/

These were generated from revision 451764 on a second run in a fresh
user data directory. Browser was terminated using chrome://quit so that
resources loading during shut down aren't included.

BUG=692670
Review-Url: https://codereview.chromium.org/2698913007
Cr-Commit-Position: refs/heads/master@{#452042}
Committed: https://chromium.googlesource.com/chromium/src/+/4ed763c0d65098ab8be5c22040697b4e013311be

[Alexei Svitkine (slow), 2017-02-17 20:34:25]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 20:35:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-02-17 20:36:27]

Description was changed from

==========
Provide startup resource numbering files for Mac and Windows.

This uses the mechanism that was added in the
https://codereview.chromium.org/2690263004/ to provide startup
resource order lists on Mac and Windows. The resources in these
files be assigned the specified ids so that they're packed in
the order that they're expected to be loaded on startup.

These files were generated using the script and README.md
instructions being added in:
  https://codereview.chromium.org/2696303003/

BUG=692670
==========

to

==========
Provide startup resource numbering files for Mac and Windows.

The resources in these files will be assigned the specified ids so that
they're packed in the order that they're expected to be loaded on startup.

This should reduce page faults incurred on start up and improve startup
performance - especially on systems where I/O is slow.

This uses the mechanism added in the following CL to do the renumbering:
https://codereview.chromium.org/2690263004/

These files were generated using the script and README.md
instructions being added in:
  https://codereview.chromium.org/2696303003/

BUG=692670
==========

[Alexei Svitkine (slow), 2017-02-17 20:37:09]

asvitkine@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-02-17 21:51:14]

Please provide enough details to recreate these results (need at least the
chromium revision you used locally and the args.gn you used in addition to
what's there; ideally full command lines) in the CL description.

https://codereview.chromium.org/2698913007/diff/1/tools/grit/grit_rule.gni
File tools/grit/grit_rule.gni (right):

https://codereview.chromium.org/2698913007/diff/1/tools/grit/grit_rule.gni#ne...
tools/grit/grit_rule.gni:260: }
TODO for linux, android, chromeos, ios?

https://codereview.chromium.org/2698913007/diff/1/tools/gritsettings/startup_...
File tools/gritsettings/startup_resources_win.txt (right):

https://codereview.chromium.org/2698913007/diff/1/tools/gritsettings/startup_...
tools/gritsettings/startup_resources_win.txt:1:
IDR_MOJO_CONTENT_BROWSER_MANIFEST 101
Wow why is the order here so different.

[Alexei Svitkine (slow), 2017-02-17 22:11:17]

"Please provide enough details to recreate these results (need at least the
chromium revision you used locally and the args.gn you used in addition to
what's there; ideally full command lines) in the CL description."

Does the info in README.md suffice?

https://codereview.chromium.org/2698913007/diff/1/tools/grit/grit_rule.gni
File tools/grit/grit_rule.gni (right):

https://codereview.chromium.org/2698913007/diff/1/tools/grit/grit_rule.gni#ne...
tools/grit/grit_rule.gni:260: }
On 2017/02/17 21:51:13, Nico wrote:
> TODO for linux, android, chromeos, ios?

Done.

https://codereview.chromium.org/2698913007/diff/1/tools/gritsettings/startup_...
File tools/gritsettings/startup_resources_win.txt (right):

https://codereview.chromium.org/2698913007/diff/1/tools/gritsettings/startup_...
tools/gritsettings/startup_resources_win.txt:1:
IDR_MOJO_CONTENT_BROWSER_MANIFEST 101
On 2017/02/17 21:51:13, Nico wrote:
> Wow why is the order here so different.

Mac ends up localizing all of its XIBs on startup.

[Nico, 2017-02-17 22:16:38]

the readme doesn't mention at which chromium revision you built these files (?)

[Alexei Svitkine (slow), 2017-02-17 22:26:53]

Unfortunately I don't have that anymore. I've since synced on both of the
machines - and they were at different revisions to begin with.

I can re-create these files Monday after I rebuilt official builds and
re-run the scripts.

I suspect they won't change. But I can add the revisions then.

On Fri, Feb 17, 2017 at 5:16 PM, <thakis@chromium.org> wrote:

> the readme doesn't mention at which chromium revision you built these
> files (?)
>
> https://codereview.chromium.org/2698913007/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2017-02-17 22:29:37]

Probably a good exercise to check how stable these files are in the short
term anyhow :-)

On Fri, Feb 17, 2017 at 5:26 PM, Alexei Svitkine <asvitkine@chromium.org>
wrote:

> Unfortunately I don't have that anymore. I've since synced on both of the
> machines - and they were at different revisions to begin with.
>
> I can re-create these files Monday after I rebuilt official builds and
> re-run the scripts.
>
> I suspect they won't change. But I can add the revisions then.
>
> On Fri, Feb 17, 2017 at 5:16 PM, <thakis@chromium.org> wrote:
>
>> the readme doesn't mention at which chromium revision you built these
>> files (?)
>>
>> https://codereview.chromium.org/2698913007/
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Alexei Svitkine (slow), 2017-02-17 23:00:04]

Sounds good. Can you take a look at my C++ cl again? Hopefully I can sync
to a fresh tot Monday and generate from that if that cl lands.

On Feb 17, 2017 5:29 PM, "Nico Weber" <thakis@chromium.org> wrote:

> Probably a good exercise to check how stable these files are in the short
> term anyhow :-)
>
> On Fri, Feb 17, 2017 at 5:26 PM, Alexei Svitkine <asvitkine@chromium.org>
> wrote:
>
>> Unfortunately I don't have that anymore. I've since synced on both of the
>> machines - and they were at different revisions to begin with.
>>
>> I can re-create these files Monday after I rebuilt official builds and
>> re-run the scripts.
>>
>> I suspect they won't change. But I can add the revisions then.
>>
>> On Fri, Feb 17, 2017 at 5:16 PM, <thakis@chromium.org> wrote:
>>
>>> the readme doesn't mention at which chromium revision you built these
>>> files (?)
>>>
>>> https://codereview.chromium.org/2698913007/
>>>
>>
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2017-02-17 23:17:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 23:17:02]

Dry run: This issue passed the CQ dry run.

[Nico, 2017-02-17 23:24:25]

done

On Fri, Feb 17, 2017 at 6:00 PM, Alexei Svitkine <asvitkine@chromium.org>
wrote:

> Sounds good. Can you take a look at my C++ cl again? Hopefully I can sync
> to a fresh tot Monday and generate from that if that cl lands.
>
> On Feb 17, 2017 5:29 PM, "Nico Weber" <thakis@chromium.org> wrote:
>
>> Probably a good exercise to check how stable these files are in the short
>> term anyhow :-)
>>
>> On Fri, Feb 17, 2017 at 5:26 PM, Alexei Svitkine <asvitkine@chromium.org>
>> wrote:
>>
>>> Unfortunately I don't have that anymore. I've since synced on both of
>>> the machines - and they were at different revisions to begin with.
>>>
>>> I can re-create these files Monday after I rebuilt official builds and
>>> re-run the scripts.
>>>
>>> I suspect they won't change. But I can add the revisions then.
>>>
>>> On Fri, Feb 17, 2017 at 5:16 PM, <thakis@chromium.org> wrote:
>>>
>>>> the readme doesn't mention at which chromium revision you built these
>>>> files (?)
>>>>
>>>> https://codereview.chromium.org/2698913007/
>>>>
>>>
>>>
>>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Alexei Svitkine (slow), 2017-02-18 00:41:16]

Thanks! And by Monday I mean Tuesday since Monday is a holiday here..

On Feb 17, 2017 6:24 PM, "Nico Weber" <thakis@chromium.org> wrote:

> done
>
> On Fri, Feb 17, 2017 at 6:00 PM, Alexei Svitkine <asvitkine@chromium.org>
> wrote:
>
>> Sounds good. Can you take a look at my C++ cl again? Hopefully I can sync
>> to a fresh tot Monday and generate from that if that cl lands.
>>
>> On Feb 17, 2017 5:29 PM, "Nico Weber" <thakis@chromium.org> wrote:
>>
>>> Probably a good exercise to check how stable these files are in the
>>> short term anyhow :-)
>>>
>>> On Fri, Feb 17, 2017 at 5:26 PM, Alexei Svitkine <asvitkine@chromium.org
>>> > wrote:
>>>
>>>> Unfortunately I don't have that anymore. I've since synced on both of
>>>> the machines - and they were at different revisions to begin with.
>>>>
>>>> I can re-create these files Monday after I rebuilt official builds and
>>>> re-run the scripts.
>>>>
>>>> I suspect they won't change. But I can add the revisions then.
>>>>
>>>> On Fri, Feb 17, 2017 at 5:16 PM, <thakis@chromium.org> wrote:
>>>>
>>>>> the readme doesn't mention at which chromium revision you built these
>>>>> files (?)
>>>>>
>>>>> https://codereview.chromium.org/2698913007/
>>>>>
>>>>
>>>>
>>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Alexei Svitkine (slow), 2017-02-21 17:47:21]

Description was changed from

==========
Provide startup resource numbering files for Mac and Windows.

The resources in these files will be assigned the specified ids so that
they're packed in the order that they're expected to be loaded on startup.

This should reduce page faults incurred on start up and improve startup
performance - especially on systems where I/O is slow.

This uses the mechanism added in the following CL to do the renumbering:
https://codereview.chromium.org/2690263004/

These files were generated using the script and README.md
instructions being added in:
  https://codereview.chromium.org/2696303003/

BUG=692670
==========

to

==========
Provide startup resource numbering files for Mac and Windows.

The resources in these files will be assigned the specified ids so that
they're packed in the order that they're expected to be loaded on startup.

This should reduce page faults incurred on start up and improve startup
performance - especially on systems where I/O is slow.

This uses the mechanism added in the following CL to do the renumbering:
https://codereview.chromium.org/2690263004/

These files were generated using the script and README.md
instructions being added in:
  https://codereview.chromium.org/2696303003/

These were generated from revision 451764 on a second run in a fresh
user data directory. Browser was terminated using chrome://quit so that
resources loading during shut down aren't included.

BUG=692670
==========

[Alexei Svitkine (slow), 2017-02-21 17:49:34]

Updated these and added revision information to the CL description.

Turns out there was some movement in the resources since my original run.

PTAL. I'm hoping to land these today so we can start seeing its results starting
from tomorrow's canary. Thanks!

[Alexei Svitkine (slow), 2017-02-21 21:15:28]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 21:17:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-02-21 22:31:20]

lgtm

Hm, doesn't look like this is super stable I guess :-/

If you still happen to have the build setup, can you check if it's very
different in a fresh user data dir and a used one?

[Alexei Svitkine (slow), 2017-02-21 22:36:43]

On 2017/02/21 22:31:20, Nico wrote:
> lgtm
> 
> Hm, doesn't look like this is super stable I guess :-/
> 
> If you still happen to have the build setup, can you check if it's very
> different in a fresh user data dir and a used one?

Yeah, I noticed that too and checked it. It doesn't seem entirely stable
run-to-run. Even with same user data dir, here's a diff of two subsequence runs
(I ran these through a command-line that stripped the id numbers to make the
diff easier):

 IDS_WEBSTORE_URL
 IDS_EXTENSION_WEB_STORE_TITLE
 IDR_EXTENSIONS_FAVICON
+IDS_EXTENSION_PROMPT_WARNING_CLIPBOARD_READWRITE
+IDS_EXTENSION_PROMPT_WARNING_NOTIFICATIONS
 IDS_EXTENSION_USB_DEVICE_PRODUCT_NAME_AND_VENDOR
 IDS_BOOKMARK_BAR_MANAGED_FOLDER_DEFAULT_NAME
 IDS_BOOKMARK_BAR_SUPERVISED_FOLDER_DEFAULT_NAME
@@ -253,14 +255,20 @@
 IDR_MOST_VISITED_SINGLE_CSS
 IDR_MOST_VISITED_SINGLE_JS
 IDR_NEWTAB_CHROME_WELCOME_PAGE_THUMBNAIL
-IDR_PRODUCT_LOGO_16
 IDR_NEWTAB_WEBSTORE_THUMBNAIL
+IDR_PRODUCT_LOGO_16
 IDR_WEBSTORE_ICON_16
 IDR_CLOSE_3_MASK
-IDS_UTILITY_PROCESS_EXTENSION_UNPACKER_NAME
 IDS_AUTOCOMPLETE_SEARCH_DESCRIPTION
 IDS_AUTOCOMPLETE_MATCH_DESCRIPTION_SEPARATOR
 IDR_OVERLAY_DROP_SHADOW
 IDS_ANNOUNCEMENT_COMPLETION_AVAILABLE_MAC
-IDS_EXTENSION_PROMPT_WARNING_CLIPBOARD_READWRITE
-IDS_EXTENSION_PROMPT_WARNING_NOTIFICATIONS

[Alexei Svitkine (slow), 2017-02-21 22:37:32]

The CQ bit was unchecked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2017-02-21 22:37:37]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2017-02-21 22:38:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 23:20:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 23:20:52]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[Alexei Svitkine (slow), 2017-02-21 23:56:33]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2017-02-21 23:57:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 00:42:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 00:42:25]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[Alexei Svitkine (slow), 2017-02-22 01:52:27]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2017-02-22 01:53:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 02:01:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 02:01:03]

Exceeded global retry quota

[Alexei Svitkine (slow), 2017-02-22 02:19:38]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2017-02-22 02:20:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 03:56:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 03:56:08]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[Alexei Svitkine (slow), 2017-02-22 04:20:47]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2017-02-22 04:21:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 04:42:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 04:42:23]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Alexei Svitkine (slow), 2017-02-22 04:46:35]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2017-02-22 04:47:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 09:40:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 09:40:11]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alexei Svitkine (slow), 2017-02-22 13:50:41]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2017-02-22 13:51:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 14:44:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487771441657580,
"parent_rev": "248635a7e9e48fdebb242b60e81c46e90fca35e7", "commit_rev":
"4ed763c0d65098ab8be5c22040697b4e013311be"}

[commit-bot: I haz the power, 2017-02-22 14:44:54]

Description was changed from

==========
Provide startup resource numbering files for Mac and Windows.

The resources in these files will be assigned the specified ids so that
they're packed in the order that they're expected to be loaded on startup.

This should reduce page faults incurred on start up and improve startup
performance - especially on systems where I/O is slow.

This uses the mechanism added in the following CL to do the renumbering:
https://codereview.chromium.org/2690263004/

These files were generated using the script and README.md
instructions being added in:
  https://codereview.chromium.org/2696303003/

These were generated from revision 451764 on a second run in a fresh
user data directory. Browser was terminated using chrome://quit so that
resources loading during shut down aren't included.

BUG=692670
==========

to

==========
Provide startup resource numbering files for Mac and Windows.

The resources in these files will be assigned the specified ids so that
they're packed in the order that they're expected to be loaded on startup.

This should reduce page faults incurred on start up and improve startup
performance - especially on systems where I/O is slow.

This uses the mechanism added in the following CL to do the renumbering:
https://codereview.chromium.org/2690263004/

These files were generated using the script and README.md
instructions being added in:
  https://codereview.chromium.org/2696303003/

These were generated from revision 451764 on a second run in a fresh
user data directory. Browser was terminated using chrome://quit so that
resources loading during shut down aren't included.

BUG=692670

Review-Url: https://codereview.chromium.org/2698913007
Cr-Commit-Position: refs/heads/master@{#452042}
Committed:
https://chromium.googlesource.com/chromium/src/+/4ed763c0d65098ab8be5c2204069...
==========

[commit-bot: I haz the power, 2017-02-22 14:44:55]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4ed763c0d65098ab8be5c2204069...