Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2698853002: [merge-m57] Forward declare blink::mojom::EngagementLevel in Document.h (Closed)

Created:
3 years, 10 months ago by tapted
Modified:
3 years, 10 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[merge-m57] Forward declare blink::mojom::EngagementLevel in Document.h Similar to https://codereview.chromium.org/2677543003/ but with presubmit fixes. r439726 added a #include for site_engagement.mojom-blink.h to Document.h without adding the necessary public_deps to build files. We can avoid adding more build dependencies to Document.h with a forward declare, so do that. Sheriff landing TBR to fix Pri-0 builder issues. BUG=687707, 692813 Also bugs: 688353, 682986 TBR=mgiuca@chromium.org Review-Url: https://codereview.chromium.org/2677003002 Cr-Commit-Position: refs/heads/master@{#448224} (cherry picked from commit f8ca4752e20998b51f7bc1cac9c651db80302bed) Review-Url: https://codereview.chromium.org/2698853002 . Cr-Commit-Position: refs/branch-heads/2987@{#534} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/d6184b6f1fd91a6ff4422993b2d0e2994fec50c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M third_party/WebKit/Source/core/dom/Document.h View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
tapted
3 years, 10 months ago (2017-02-16 00:56:06 UTC) #1
tapted
3 years, 10 months ago (2017-02-16 00:56:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d6184b6f1fd91a6ff4422993b2d0e2994fec50c7.

Powered by Google App Engine
This is Rietveld 408576698