Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2677003002: Foward declare blink::mojom::EngagementLevel in Document.h (Closed)

Created:
3 years, 10 months ago by tapted
Modified:
3 years, 10 months ago
Reviewers:
dominickn, sof
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis, chrome-apps-syd-reviews_chromium.org, Arjan van Leeuwen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Forward declare blink::mojom::EngagementLevel in Document.h Similar to https://codereview.chromium.org/2677543003/ but with presubmit fixes. r439726 added a #include for site_engagement.mojom-blink.h to Document.h without adding the necessary public_deps to build files. We can avoid adding more build dependencies to Document.h with a forward declare, so do that. Sheriff landing TBR to fix Pri-0 builder issues. BUG=687707, 688353, 682986 TBR=sof@chromium.org Review-Url: https://codereview.chromium.org/2677003002 Cr-Commit-Position: refs/heads/master@{#448224} Committed: https://chromium.googlesource.com/chromium/src/+/f8ca4752e20998b51f7bc1cac9c651db80302bed

Patch Set 1 #

Patch Set 2 : cl format #

Patch Set 3 : move <memory> to bottom #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M third_party/WebKit/Source/core/dom/Document.h View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
tapted
3 years, 10 months ago (2017-02-06 03:27:32 UTC) #6
dominickn
lgtm
3 years, 10 months ago (2017-02-06 03:28:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677003002/40001
3 years, 10 months ago (2017-02-06 04:03:18 UTC) #13
sof
lgtm, thanks tapted@.
3 years, 10 months ago (2017-02-06 06:14:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2677003002/40001
3 years, 10 months ago (2017-02-06 06:19:28 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 09:36:19 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f8ca4752e20998b51f7bc1cac9c6...

Powered by Google App Engine
This is Rietveld 408576698