Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 2698843003: Convert more miscellaneous tests to testharness (Closed)

Created:
3 years, 10 months ago by Raymond Toy
Modified:
3 years, 9 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert more miscellaneous tests to testharness Manually converted these miscellaneous tests to use testharness and new Audit. BUG=692795 TEST=audiosummingjunction-crash.html, test-basic.html Review-Url: https://codereview.chromium.org/2698843003 Cr-Commit-Position: refs/heads/master@{#453320} Committed: https://chromium.googlesource.com/chromium/src/+/2a5e6e00828ef68ffd416555347aa710a163d3f4

Patch Set 1 #

Patch Set 2 : Rebase and remove task.describe #

Patch Set 3 : Rebase #

Patch Set 4 : Shorten description #

Total comments: 4

Patch Set 5 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -40 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash.html View 1 2 3 4 1 chunk +22 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/test-basic.html View 1 2 3 4 1 chunk +38 lines, -30 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Raymond Toy
PTAL
3 years, 9 months ago (2017-02-27 17:38:40 UTC) #3
hongchan
lgtm with nits https://codereview.chromium.org/2698843003/diff/60001/third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash.html File third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash.html (right): https://codereview.chromium.org/2698843003/diff/60001/third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash.html#newcode15 third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash.html:15: let ac = new AudioContext(); ac ...
3 years, 9 months ago (2017-02-27 18:21:52 UTC) #4
Raymond Toy
https://codereview.chromium.org/2698843003/diff/60001/third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash.html File third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash.html (right): https://codereview.chromium.org/2698843003/diff/60001/third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash.html#newcode15 third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash.html:15: let ac = new AudioContext(); On 2017/02/27 18:21:52, hongchan ...
3 years, 9 months ago (2017-02-27 18:51:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698843003/80001
3 years, 9 months ago (2017-02-27 18:52:41 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 20:35:21 UTC) #11
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/2a5e6e00828ef68ffd416555347a...

Powered by Google App Engine
This is Rietveld 408576698