Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash.html

Issue 2698843003: Convert more miscellaneous tests to testharness (Closed)
Patch Set: Address review comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash.html b/third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash.html
index d00cdde00e60684df0a5ec68b44a79caa86091ba..3074e4948b287ba54f591d648acf37c4c0529554 100644
--- a/third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash.html
+++ b/third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash.html
@@ -1,10 +1,26 @@
<body>
-<script src="../resources/js-test.js">
+<script src="../resources/testharness.js"></script>
+<script src="../resources/testharnessreport.js"></script>
+<script src="resources/audit.js"></script>
<script>
-description("This test passes if it doesn't crash.");
-var ac = new AudioContext();
-var node = ac.createChannelMerger(4);
-node.connect(ac.createMediaStreamDestination(), 0);
-gc();
+let audit = Audit.createTaskRunner();
+
+audit.define(
+ {
+ label: 'test',
+ description:
+ 'Test connection from ChannelMerger to MediaStreamAudioDestination'
+ },
+ (task, should) => {
+ let context = new AudioContext();
+ let node = context.createChannelMerger(4);
+ node.connect(context.createMediaStreamDestination(), 0);
+ gc();
+ // Test passes if we get here because we didn't crash
+ should(true, 'Test survived GC').message('correctly', 'incorrectly');
+ task.done();
+ });
+
+audit.run();
</script>
</body>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/audiosummingjunction-crash-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698