[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files. Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
List of components
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
Review-Url: https://codereview.chromium.org/2698763002
Cr-Commit-Position: refs/heads/master@{#451336}
Committed: https://chromium.googlesource.com/chromium/src/+/b3d3b8331c1cb0807b916a871b7801788087f713

[ymzhang1, 2017-02-15 22:13:46]

ymzhang@chromium.org changed reviewers:
+ jln@chromium.org, mdempsky@chromium.org

[ymzhang1, 2017-02-15 22:13:47]

Hello,

We are adding COMPONENT/TEAM information into OWNERS file. Would you mind
helping us to verify the added TEAM/COMPONENT or suggest the correct
TEAM/COMPONENT in your OWNERS files? Thank you very much!

[mdempsky, 2017-02-15 22:21:39]

https://codereview.chromium.org/2698763002/diff/1/content/zygote/OWNERS
File content/zygote/OWNERS (right):

https://codereview.chromium.org/2698763002/diff/1/content/zygote/OWNERS#newcode6
content/zygote/OWNERS:6: # COMPONENT: Internals>Core
content/zygote is really a sandbox feature. This file should match
sandbox/linux/OWNERS.

[ymzhang1, 2017-02-15 22:25:48]

Patchset #2 (id:20001) has been deleted

[ymzhang1, 2017-02-15 22:27:28]

https://codereview.chromium.org/2698763002/diff/1/content/zygote/OWNERS
File content/zygote/OWNERS (right):

https://codereview.chromium.org/2698763002/diff/1/content/zygote/OWNERS#newcode6
content/zygote/OWNERS:6: # COMPONENT: Internals>Core
On 2017/02/15 22:21:39, mdempsky wrote:
> content/zygote is really a sandbox feature. This file should match
> sandbox/linux/OWNERS.

Internals>Sandbox?

[mdempsky, 2017-02-15 22:33:28]

https://codereview.chromium.org/2698763002/diff/1/content/zygote/OWNERS
File content/zygote/OWNERS (right):

https://codereview.chromium.org/2698763002/diff/1/content/zygote/OWNERS#newcode6
content/zygote/OWNERS:6: # COMPONENT: Internals>Core
On 2017/02/15 22:27:28, ymzhang1 wrote:
> Internals>Sandbox?

Yeah, and security-dev@ if you want to include an email group.

[mdempsky, 2017-02-15 22:34:15]

https://codereview.chromium.org/2698763002/diff/40001/content/browser/zygote_...
File content/browser/zygote_host/OWNERS (right):

https://codereview.chromium.org/2698763002/diff/40001/content/browser/zygote_...
content/browser/zygote_host/OWNERS:6: # COMPONENT: Internals>Core
Oops, and same here too.

[ymzhang1, 2017-02-15 22:40:42]

ymzhang@chromium.org changed reviewers:
+ gab@chromium.org

[ymzhang1, 2017-02-15 22:40:42]

Yeah, very happy to get team information!

+ gab@chromium.org: Please review changes in 
base/strings/OWNERS

https://codereview.chromium.org/2698763002/diff/40001/content/browser/zygote_...
File content/browser/zygote_host/OWNERS (right):

https://codereview.chromium.org/2698763002/diff/40001/content/browser/zygote_...
content/browser/zygote_host/OWNERS:6: # COMPONENT: Internals>Core
On 2017/02/15 22:34:15, mdempsky wrote:
> Oops, and same here too.

Done.

[mdempsky, 2017-02-15 23:05:09]

LGTM for zygote+sandbox OWNERS.

https://codereview.chromium.org/2698763002/diff/60001/base/strings/OWNERS
File base/strings/OWNERS (right):

https://codereview.chromium.org/2698763002/diff/60001/base/strings/OWNERS#new...
base/strings/OWNERS:4: # COMPONENT: Blink>HTML>Base
I would suggest omitting this. Whatever COMPONENT is used in base/OWNERS is
probably correct here too.

[gab, 2017-02-16 00:07:36]

https://codereview.chromium.org/2698763002/diff/60001/base/strings/OWNERS
File base/strings/OWNERS (right):

https://codereview.chromium.org/2698763002/diff/60001/base/strings/OWNERS#new...
base/strings/OWNERS:4: # COMPONENT: Blink>HTML>Base
On 2017/02/15 23:05:09, mdempsky wrote:
> I would suggest omitting this. Whatever COMPONENT is used in base/OWNERS is
> probably correct here too.

Agreed

[ymzhang1, 2017-02-16 00:14:24]

https://codereview.chromium.org/2698763002/diff/60001/base/strings/OWNERS
File base/strings/OWNERS (right):

https://codereview.chromium.org/2698763002/diff/60001/base/strings/OWNERS#new...
base/strings/OWNERS:4: # COMPONENT: Blink>HTML>Base
On 2017/02/16 00:07:35, gab wrote:
> On 2017/02/15 23:05:09, mdempsky wrote:
> > I would suggest omitting this. Whatever COMPONENT is used in base/OWNERS is
> > probably correct here too.
> 
> Agreed

Thanks! I'll put Internals>Core as in base/OWNERS.

[mdempsky, 2017-02-16 02:16:19]

On 2017/02/16 00:14:24, ymzhang1 wrote:
> Thanks! I'll put Internals>Core as in base/OWNERS.

Is there a reason to not just omit it? Do COMPONENTS not inherit like OWNERS do?

[gab, 2017-02-16 12:46:23]

On 2017/02/16 02:16:19, mdempsky wrote:
> On 2017/02/16 00:14:24, ymzhang1 wrote:
> > Thanks! I'll put Internals>Core as in base/OWNERS.
> 
> Is there a reason to not just omit it? Do COMPONENTS not inherit like OWNERS
do?

I also prefer omitting

[ymzhang1, 2017-02-16 21:55:29]

On 2017/02/16 12:46:23, gab wrote:
> On 2017/02/16 02:16:19, mdempsky wrote:
> > On 2017/02/16 00:14:24, ymzhang1 wrote:
> > > Thanks! I'll put Internals>Core as in base/OWNERS.
> > 
> > Is there a reason to not just omit it? Do COMPONENTS not inherit like OWNERS
> do?
> 
> I also prefer omitting

Sure. I would remove this line. Yes, in the end, the COMPONENTS will inherit
like OWNERS do. 

A small reason for not omitting previously.

When a OWNERS file doesn't have COMPONENT information, the directory is:
1. waiting for a new component, and the new component will be added in the
future.
2. a sub-directory which has same component as parent directory.
3. touching too many things and no single component fits.
4. not verified by any owner.

I have maintained lists of 1,2,3. However, currently when computing
COMPONENT/TEAM coverage in OWENRS files (percentage of files have COMPONENT/TEAM
information), we didn't distinguish between these four cases (as most OWNERS
missing COMPONENT due to 4 now).

[mdempsky, 2017-02-16 21:59:43]

LGTM

[ymzhang1, 2017-02-16 22:00:02]

The CQ bit was checked by ymzhang@chromium.org

[commit-bot: I haz the power, 2017-02-16 22:01:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 00:10:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 00:10:59]

Failed to apply patch for sandbox/linux/OWNERS:
While running git apply --index -p1;
  error: patch failed: sandbox/linux/OWNERS:2
  error: sandbox/linux/OWNERS: patch does not apply

Patch:       sandbox/linux/OWNERS
Index: sandbox/linux/OWNERS
diff --git a/sandbox/linux/OWNERS b/sandbox/linux/OWNERS
index
99ef1bd9612f8329b4c83c26a320a6795583b53d..b349921eae66c0f50eb297223c2b2b43a421724c
100644
--- a/sandbox/linux/OWNERS
+++ b/sandbox/linux/OWNERS
@@ -2,3 +2,6 @@ jln@chromium.org
 jorgelo@chromium.org
 mdempsky@chromium.org
 rickyz@chromium.org
+
+# TEAM: security-dev@chromium.org
+# COMPONENT: Internals>Sandbox

[ymzhang1, 2017-02-17 17:42:11]

The CQ bit was checked by ymzhang@chromium.org

[ymzhang1, 2017-02-17 17:42:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
mdempsky@chromium.org
Link to the patchset: https://codereview.chromium.org/2698763002/#ps120001
(title: "Merge branch 'master' of https://chromium.googlesource.com/chromium/src
into mde_adding")

[commit-bot: I haz the power, 2017-02-17 17:42:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 17:54:02]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1487353331392670,
"parent_rev": "a16c9bad4d2c9f5a713442c7a4a0651d85780406", "commit_rev":
"b3d3b8331c1cb0807b916a871b7801788087f713"}

[commit-bot: I haz the power, 2017-02-17 17:54:39]

Description was changed from

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files. Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
List of components
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
==========

to

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files. Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
List of components
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905

Review-Url: https://codereview.chromium.org/2698763002
Cr-Commit-Position: refs/heads/master@{#451336}
Committed:
https://chromium.googlesource.com/chromium/src/+/b3d3b8331c1cb0807b916a871b78...
==========

[commit-bot: I haz the power, 2017-02-17 17:54:42]

Committed patchset #6 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/b3d3b8331c1cb0807b916a871b78...