base/strings/OWNERS - Issue 2698763002: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/strings/OWNERS

Issue 2698763002: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Patch Set: ADD TEAM Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 per-file safe_sprintf*=jln@chromium.org	1 per-file safe_sprintf*=jln@chromium.org

2 per-file safe_sprintf*=mdempsky@chromium.org	2 per-file safe_sprintf*=mdempsky@chromium.org

	3

	4 # COMPONENT: Blink>HTML>Base
	mdempsky 2017/02/15 23:05:09 I would suggest omitting this. Whatever COMPONENT I would suggest omitting this. Whatever COMPONENT is used in base/OWNERS is probably correct here too. gab 2017/02/16 00:07:35 Agreed Show quoted text On 2017/02/15 23:05:09, mdempsky wrote: > I would suggest omitting this. Whatever COMPONENT is used in base/OWNERS is > probably correct here too. Agreed ymzhang1 2017/02/16 00:14:24 Thanks! I'll put Internals>Core as in base/OWNERS. Show quoted text On 2017/02/16 00:07:35, gab wrote: > On 2017/02/15 23:05:09, mdempsky wrote: > > I would suggest omitting this. Whatever COMPONENT is used in base/OWNERS is > > probably correct here too. > > Agreed Thanks! I'll put Internals>Core as in base/OWNERS.
OLD	NEW

« no previous file with comments | « no previous file | content/browser/zygote_host/OWNERS » ('j') | no next file with comments »