Chromium Code Reviews
Help | Chromium Project | Sign in
(3)

Issue 2698703005: Use correct interface name in preferences_manifest.json. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by leonhsl
Modified:
2 months, 1 week ago
Reviewers:
jonross, sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use correct interface name in preferences_manifest.json. Should be prefs::mojom::PreferencesServiceFactory, instead of prefs::mojom::PreferencesFactory. Otherwise there would have bellowing ERROR log: [99556:99581:0217/140056.829661:ERROR:service_manager.cc(209)] Connection InterfaceProviderSpec prevented service: content_browser from binding interface: prefs::mojom::PreferencesServiceFactory exposed by: preferences BUG=

Patch Set 1 #

Messages

Total messages: 11 (9 generated)
leonhsl
PTAL, Thanks.
2 months, 1 week ago (2017-02-17 07:05:05 UTC) #4
jonross
2 months, 1 week ago (2017-02-17 10:52:05 UTC) #11
On 2017/02/17 07:05:05, leonhsl wrote:
> PTAL, Thanks.

Thanks for spotting this. We currently have this covered in a patch that
addresses a few other errors with preferences as well:
https://codereview.chromium.org/2698913005/ so we can just land that instead.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46