Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1297)

Issue 2698703005: Use correct interface name in preferences_manifest.json. (Closed)

Created:
1 year, 3 months ago by leonhsl(Using Gerrit)
Modified:
1 year, 3 months ago
Reviewers:
jonross, sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use correct interface name in preferences_manifest.json. Should be prefs::mojom::PreferencesServiceFactory, instead of prefs::mojom::PreferencesFactory. Otherwise there would have bellowing ERROR log: [99556:99581:0217/140056.829661:ERROR:service_manager.cc(209)] Connection InterfaceProviderSpec prevented service: content_browser from binding interface: prefs::mojom::PreferencesServiceFactory exposed by: preferences BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/prefs/preferences_manifest.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (9 generated)
leonhsl(Using Gerrit)
PTAL, Thanks.
1 year, 3 months ago (2017-02-17 07:05:05 UTC) #4
jonross
1 year, 3 months ago (2017-02-17 10:52:05 UTC) #11
On 2017/02/17 07:05:05, leonhsl wrote:
> PTAL, Thanks.

Thanks for spotting this. We currently have this covered in a patch that
addresses a few other errors with preferences as well:
https://codereview.chromium.org/2698913005/ so we can just land that instead.

Powered by Google App Engine
This is Rietveld 408576698