Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2698913005: Re-enable preferences service access for browser+ash (Closed)

Created:
3 years, 10 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 10 months ago
Reviewers:
jonross, sky
CC:
chromium-reviews, davemoore+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable preferences service access for browser+ash Fixes the preferences manifest to provide the correct interface. Adds a browser test to ensure that the browser can connect to the preferences service and change / observer the default profile PrefStore. Also fixes a bug where PrefStoreClient was using path expansion when setting dictionary keys, even though it's backed by a flat key-value store. BUG=None TEST=browser_tests/PreferencesServiceBrowserTest.Basic Review-Url: https://codereview.chromium.org/2698913005 Cr-Commit-Position: refs/heads/master@{#451452} Committed: https://chromium.googlesource.com/chromium/src/+/905e389f8130659ead4b44dad07f976605622025

Patch Set 1 #

Patch Set 2 : . #

Total comments: 9

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -4 lines) Patch
M chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/preferences_chromeos_browsertest.cc View 1 2 4 chunks +108 lines, -0 lines 0 comments Download
M chrome/browser/prefs/preferences_manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/preferences_service.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M services/preferences/public/cpp/pref_client_store.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 46 (27 generated)
Ken Rockot(use gerrit already)
Jon PTAL overall, thanks!
3 years, 10 months ago (2017-02-16 21:22:28 UTC) #5
jonross
Looks mostly great, thanks for spotting this! A few testing related questions. https://codereview.chromium.org/2698913005/diff/20001/chrome/browser/chromeos/preferences_chromeos_browsertest.cc File chrome/browser/chromeos/preferences_chromeos_browsertest.cc ...
3 years, 10 months ago (2017-02-16 21:53:35 UTC) #9
Ken Rockot(use gerrit already)
https://codereview.chromium.org/2698913005/diff/20001/chrome/browser/chromeos/preferences_chromeos_browsertest.cc File chrome/browser/chromeos/preferences_chromeos_browsertest.cc (right): https://codereview.chromium.org/2698913005/diff/20001/chrome/browser/chromeos/preferences_chromeos_browsertest.cc#newcode194 chrome/browser/chromeos/preferences_chromeos_browsertest.cc:194: if (key == pref_name_) On 2017/02/16 at 21:53:35, jonross ...
3 years, 10 months ago (2017-02-17 00:00:32 UTC) #12
jonross
LGTM https://codereview.chromium.org/2698913005/diff/20001/chrome/browser/chromeos/preferences_chromeos_browsertest.cc File chrome/browser/chromeos/preferences_chromeos_browsertest.cc (right): https://codereview.chromium.org/2698913005/diff/20001/chrome/browser/chromeos/preferences_chromeos_browsertest.cc#newcode194 chrome/browser/chromeos/preferences_chromeos_browsertest.cc:194: if (key == pref_name_) On 2017/02/17 00:00:31, Ken ...
3 years, 10 months ago (2017-02-17 02:15:46 UTC) #13
Ken Rockot(use gerrit already)
Thanks! On Feb 16, 2017 6:15 PM, <jonross@chromium.org> wrote: > LGTM > > > https://codereview.chromium.org/2698913005/diff/20001/ ...
3 years, 10 months ago (2017-02-17 02:16:50 UTC) #14
commit-bot: I haz the power
This CL has an open dependency (Issue 2695403002 Patch 80001). Please resolve the dependency and ...
3 years, 10 months ago (2017-02-17 02:18:05 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698913005/20001
3 years, 10 months ago (2017-02-17 04:52:08 UTC) #19
Ken Rockot(use gerrit already)
One more for you sky@ :) Please take a look as toplevel owner
3 years, 10 months ago (2017-02-17 04:53:42 UTC) #22
sky
https://codereview.chromium.org/2698913005/diff/20001/chrome/browser/chromeos/preferences_chromeos_browsertest.cc File chrome/browser/chromeos/preferences_chromeos_browsertest.cc (right): https://codereview.chromium.org/2698913005/diff/20001/chrome/browser/chromeos/preferences_chromeos_browsertest.cc#newcode178 chrome/browser/chromeos/preferences_chromeos_browsertest.cc:178: EXPECT_TRUE(store->GetValue(key, &value)); If this returns false, won't the next ...
3 years, 10 months ago (2017-02-17 17:44:23 UTC) #23
Ken Rockot(use gerrit already)
https://codereview.chromium.org/2698913005/diff/20001/chrome/browser/chromeos/preferences_chromeos_browsertest.cc File chrome/browser/chromeos/preferences_chromeos_browsertest.cc (right): https://codereview.chromium.org/2698913005/diff/20001/chrome/browser/chromeos/preferences_chromeos_browsertest.cc#newcode178 chrome/browser/chromeos/preferences_chromeos_browsertest.cc:178: EXPECT_TRUE(store->GetValue(key, &value)); On 2017/02/17 at 17:44:22, sky wrote: > ...
3 years, 10 months ago (2017-02-17 18:58:22 UTC) #24
sky
LGTM
3 years, 10 months ago (2017-02-17 19:26:41 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698913005/40001
3 years, 10 months ago (2017-02-17 19:32:44 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/367340)
3 years, 10 months ago (2017-02-17 20:29:25 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698913005/40001
3 years, 10 months ago (2017-02-17 21:21:39 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-17 23:24:17 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698913005/40001
3 years, 10 months ago (2017-02-17 23:59:54 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-18 02:04:46 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698913005/40001
3 years, 10 months ago (2017-02-18 09:59:57 UTC) #43
commit-bot: I haz the power
3 years, 10 months ago (2017-02-18 10:47:54 UTC) #46
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/905e389f8130659ead4b44dad07f...

Powered by Google App Engine
This is Rietveld 408576698