Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2698623008: DevTools: extract a list view out of CSSTrackerView (Closed)

Created:
3 years, 10 months ago by caseq
Modified:
3 years, 10 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: extract a list view out of CSSTrackerView This prepares CSSTrackerView for having different child views depending on the mode chosen. Review-Url: https://codereview.chromium.org/2698623008 Cr-Commit-Position: refs/heads/master@{#451878} Committed: https://chromium.googlesource.com/chromium/src/+/fe30b0bf96bd87e26885dafe9ca8c79e1c21c2b3

Patch Set 1 : similarity=10 #

Total comments: 2

Patch Set 2 : review comments + rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -401 lines) Patch
M third_party/WebKit/LayoutTests/inspector/css_tracker/css-tracker-view.html View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/css_tracker/CSSTrackerListView.js View 1 5 chunks +9 lines, -236 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/css_tracker/CSSTrackerView.js View 1 5 chunks +5 lines, -160 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/css_tracker/module.json View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
caseq
3 years, 10 months ago (2017-02-17 03:39:09 UTC) #4
alph
lgtm https://codereview.chromium.org/2698623008/diff/40001/third_party/WebKit/Source/devtools/BUILD.gn File third_party/WebKit/Source/devtools/BUILD.gn (right): https://codereview.chromium.org/2698623008/diff/40001/third_party/WebKit/Source/devtools/BUILD.gn#newcode148 third_party/WebKit/Source/devtools/BUILD.gn:148: "front_end/css_tracker/CSSTrackerListView.js", Can we have these sorted plz. https://codereview.chromium.org/2698623008/diff/40001/third_party/WebKit/Source/devtools/front_end/css_tracker/module.json ...
3 years, 10 months ago (2017-02-17 18:34:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698623008/60001
3 years, 10 months ago (2017-02-20 01:36:56 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/368136)
3 years, 10 months ago (2017-02-20 02:54:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698623008/60001
3 years, 10 months ago (2017-02-21 19:31:46 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on ...
3 years, 10 months ago (2017-02-21 21:37:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698623008/60001
3 years, 10 months ago (2017-02-21 22:59:56 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 01:41:04 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/fe30b0bf96bd87e26885dafe9ca8...

Powered by Google App Engine
This is Rietveld 408576698