Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: third_party/WebKit/LayoutTests/inspector/css_tracker/css-tracker-view.html

Issue 2698623008: DevTools: extract a list view out of CSSTrackerView (Closed)
Patch Set: review comments + rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/inspector/css_tracker/css-tracker-view.html
diff --git a/third_party/WebKit/LayoutTests/inspector/css_tracker/css-tracker-view.html b/third_party/WebKit/LayoutTests/inspector/css_tracker/css-tracker-view.html
index 5c98b6470ce7230951bbf6a38e14127b970d3eb2..132e3e415350681e175f72b9542c689a2b578534 100644
--- a/third_party/WebKit/LayoutTests/inspector/css_tracker/css-tracker-view.html
+++ b/third_party/WebKit/LayoutTests/inspector/css_tracker/css-tracker-view.html
@@ -13,9 +13,8 @@ var initialize_CSSTracker = function() {
function test()
{
- InspectorTest.addSniffer(CSSTracker.CSSTrackerView.prototype, "_updateTree", displayResults);
-
var tracker = self.runtime.sharedInstance(CSSTracker.CSSTrackerView);
+ InspectorTest.addSniffer(tracker._listView, "update", displayResults);
tracker._toggleRecording(true);
UI.viewManager.showView("css_tracker");
@@ -23,11 +22,12 @@ function test()
function displayResults()
{
- tracker._treeOutline.rootElement().firstChild().expand();
+ var treeOutline = tracker._listView._treeOutline;
+ treeOutline.rootElement().firstChild().expand();
- InspectorTest.addResult(tracker._treeOutline.element.shadowRoot.querySelectorAll(
+ InspectorTest.addResult(treeOutline.element.shadowRoot.querySelectorAll(
".rule-result-matches-count")[0].innerHTML);
- tracker._treeOutline.element.shadowRoot.querySelectorAll(".rule-match-content").forEach(
+ treeOutline.element.shadowRoot.querySelectorAll(".rule-match-content").forEach(
match => InspectorTest.addResult(match.innerHTML));
InspectorTest.completeTest();
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698