[Sync] Use ExtractIntegerValue to extract request_id from js args

[Sync] Use ExtractIntegerValue to extract request_id from js args

The scenario is: chrome_sync.js passes integer request_id when calling
getAllNodes. SyncInternalsMessageHandler::HandleGetAllNodes tries to extract
this integer with GetInteger function.

The issue is that because on iOS numeric values are passed as double,
GetInteger fails and DCHECK gets triggered.

The fix is to call ExtractIntegerValue that correctly handles converting
double to int.

BUG=692834
R=pnoland@chromium.org

Review-Url: https://codereview.chromium.org/2698603003
Cr-Commit-Position: refs/heads/master@{#451831}
Committed: https://chromium.googlesource.com/chromium/src/+/80325c70ccf2bb0cc17cca4fe30f6eaae9e278dc

[pavely, 2017-02-16 00:30:03]

The CQ bit was checked by pavely@chromium.org to run a CQ dry run

[pavely, 2017-02-16 00:30:23]

Description was changed from

==========
[Sync] Use ExtractIntegerValue to extract request_id from js args

The scenario is: chrome_sync.js passes integer request_id when calling
getAllNodes. SyncInternalsMessageHandler::HandleGetAllNodes tries to extract
this integer with GetInteger function.

The issue is that because on iOS numeric values are passed as double,
GetInteger fails.

The fix is to call ExtractIntegerValue that correctly handles converting
double to int.

BUG=692834
R=pnoland@chromium.org
==========

to

==========
[Sync] Use ExtractIntegerValue to extract request_id from js args

The scenario is: chrome_sync.js passes integer request_id when calling
getAllNodes. SyncInternalsMessageHandler::HandleGetAllNodes tries to extract
this integer with GetInteger function.

The issue is that because on iOS numeric values are passed as double,
GetInteger fails.

The fix is to call ExtractIntegerValue that correctly handles converting
double to int.

BUG=692834
R=pnoland@chromium.org
==========

[pavely, 2017-02-16 00:30:23]

pavely@chromium.org changed reviewers:
+ estade@chromium.org

[pavely, 2017-02-16 00:31:33]

Description was changed from

==========
[Sync] Use ExtractIntegerValue to extract request_id from js args

The scenario is: chrome_sync.js passes integer request_id when calling
getAllNodes. SyncInternalsMessageHandler::HandleGetAllNodes tries to extract
this integer with GetInteger function.

The issue is that because on iOS numeric values are passed as double,
GetInteger fails.

The fix is to call ExtractIntegerValue that correctly handles converting
double to int.

BUG=692834
R=pnoland@chromium.org
==========

to

==========
[Sync] Use ExtractIntegerValue to extract request_id from js args

The scenario is: chrome_sync.js passes integer request_id when calling
getAllNodes. SyncInternalsMessageHandler::HandleGetAllNodes tries to extract
this integer with GetInteger function.

The issue is that because on iOS numeric values are passed as double,
GetInteger fails and DCHECK gets triggered.

The fix is to call ExtractIntegerValue that correctly handles converting
double to int.

BUG=692834
R=pnoland@chromium.org
==========

[commit-bot: I haz the power, 2017-02-16 00:31:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pavely, 2017-02-16 01:57:00]

Patrick, PTAL.
+ Evan for owners review in chrome/browser/ui/webui/

[commit-bot: I haz the power, 2017-02-16 02:34:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 02:34:56]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Evan Stade, 2017-02-16 02:41:52]

lgtm

[Patrick Noland, 2017-02-16 18:48:12]

lgtm

[pavely, 2017-02-17 15:32:42]

The CQ bit was checked by pavely@chromium.org

[commit-bot: I haz the power, 2017-02-17 15:33:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 16:51:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 16:51:16]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pavely, 2017-02-21 18:40:48]

The CQ bit was checked by pavely@chromium.org

[commit-bot: I haz the power, 2017-02-21 18:42:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 21:07:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487702448324620, "parent_rev":
"625ed7b577525cfa4ca367841d25152133485a28", "commit_rev":
"80325c70ccf2bb0cc17cca4fe30f6eaae9e278dc"}

[commit-bot: I haz the power, 2017-02-21 21:08:08]

Description was changed from

==========
[Sync] Use ExtractIntegerValue to extract request_id from js args

The scenario is: chrome_sync.js passes integer request_id when calling
getAllNodes. SyncInternalsMessageHandler::HandleGetAllNodes tries to extract
this integer with GetInteger function.

The issue is that because on iOS numeric values are passed as double,
GetInteger fails and DCHECK gets triggered.

The fix is to call ExtractIntegerValue that correctly handles converting
double to int.

BUG=692834
R=pnoland@chromium.org
==========

to

==========
[Sync] Use ExtractIntegerValue to extract request_id from js args

The scenario is: chrome_sync.js passes integer request_id when calling
getAllNodes. SyncInternalsMessageHandler::HandleGetAllNodes tries to extract
this integer with GetInteger function.

The issue is that because on iOS numeric values are passed as double,
GetInteger fails and DCHECK gets triggered.

The fix is to call ExtractIntegerValue that correctly handles converting
double to int.

BUG=692834
R=pnoland@chromium.org

Review-Url: https://codereview.chromium.org/2698603003
Cr-Commit-Position: refs/heads/master@{#451831}
Committed:
https://chromium.googlesource.com/chromium/src/+/80325c70ccf2bb0cc17cca4fe30f...
==========

[commit-bot: I haz the power, 2017-02-21 21:08:09]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/80325c70ccf2bb0cc17cca4fe30f...