ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc - Issue 2698603003: [Sync] Use ExtractIntegerValue to extract request_id from js args

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc

Issue 2698603003: [Sync] Use ExtractIntegerValue to extract request_id from js args (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc

diff --git a/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc b/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc

index 05b2f0b81e66545895424760de3cecd911e7577a..7f4b3cbeb5957d37cc4fd7ddff2bfc6d94046f8f 100644

--- a/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc

+++ b/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc

@@ -138,7 +138,7 @@ void SyncInternalsMessageHandler::HandleGetAllNodes(

const base::ListValue* args) {

DCHECK_EQ(1U, args->GetSize());

int request_id = 0;

- bool success = args->GetInteger(0, &request_id);

+ bool success = ExtractIntegerValue(args, &request_id);

DCHECK(success);

syncer::SyncService* service = GetSyncService();

« no previous file with comments | « chrome/browser/ui/webui/sync_internals_message_handler.cc ('k') | no next file » | no next file with comments »