Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 2698473008: Implement ScreenManagerOzoneExternal::RequestCloseDisplay (Closed)

Created:
3 years, 10 months ago by fwang
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, rjkroege, tonikitoo, kylechar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement ScreenManagerOzoneExternal::RequestCloseDisplay ScreenManagerOzoneExternal::RequestCloseDisplay was added in [1] to support external windows. However RequestCloseDisplay was left unimplemented, which means that external windows can not be closed. This CL modifies that function to transmit the close request to the screen manager delegate. BUG=666958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M services/ui/display/screen_manager_ozone_external.h View 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/display/screen_manager_ozone_external.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
fwang
I tested this with the patch from https://codereview.chromium.org/2645093003/. However, I am not sure whether it ...
3 years, 10 months ago (2017-02-17 14:21:50 UTC) #4
kylechar
On 2017/02/17 14:21:50, fwang wrote: > I tested this with the patch from https://codereview.chromium.org/2645093003/. > ...
3 years, 10 months ago (2017-02-21 13:56:51 UTC) #7
fwang
3 years, 8 months ago (2017-04-03 10:21:56 UTC) #10
I'm closing this for now. I already submitted patches for closing & resizing
windows in Igalia's Chromium fork, so hopefully they could be upstreamed in the
future.

Powered by Google App Engine
This is Rietveld 408576698