Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2698413002: selection: Align collapse-NN.html and extend-NN.html to the latest draft. (Closed)

Created:
3 years, 10 months ago by tkent
Modified:
3 years, 10 months ago
Reviewers:
yoichio, yosin_UTC9
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

selection: Align collapse-NN.html and extend-NN.html to the latest draft. https://www.w3.org/TR/selection-api/#dom-selection-collapse > 3. If node's root is not the document associated with the context object, > abort these steps. https://www.w3.org/TR/selection-api/#dom-selection-extend > 1. If node's root is not the document associated with the context object, > abort these steps. Also, this CL updates Blink's extend() implementation so that the root check is done at the beginning of the function. This CL fixes 4,259 tests in web-platform-tests/selection/. BUG=683066 R=yosin@chromium.org Review-Url: https://codereview.chromium.org/2698413002 . Cr-Commit-Position: refs/heads/master@{#451299} Committed: https://chromium.googlesource.com/chromium/src/+/c6fe6ded242480abd3a1783311ecd810d2724db8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5817 lines, -8007 lines) Patch
M third_party/WebKit/LayoutTests/editing/selection/DOMSelection-DocumentType-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/DOMSelection-crossing-document-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/script-tests/DOMSelection-DocumentType.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/script-tests/DOMSelection-crossing-document.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/collapse.js View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/collapse-00-expected.txt View 91 chunks +1171 lines, -1834 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/collapse-30-expected.txt View 88 chunks +1132 lines, -1210 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/common.js View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/extend.js View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/extend-00-expected.txt View 52 chunks +1250 lines, -2147 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/extend-20-expected.txt View 58 chunks +1318 lines, -1903 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/extend-40-expected.txt View 11 chunks +871 lines, -871 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/interfaces-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/removeAllRanges-expected.txt View 5 chunks +30 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
tkent
yosin@, yoichio@, would you review this please? This CL depends on https://codereview.chromium.org/2697313005 though it seems ...
3 years, 10 months ago (2017-02-17 08:48:22 UTC) #6
yosin_UTC9
lgtm
3 years, 10 months ago (2017-02-17 09:17:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698413002/1
3 years, 10 months ago (2017-02-17 12:31:25 UTC) #13
tkent
3 years, 10 months ago (2017-02-17 14:15:19 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c6fe6ded242480abd3a1783311ecd810d2724db8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698