Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/155513) ios-device-xcode-clang on ...
3 years, 10 months ago
(2017-02-17 08:45:11 UTC)
#4
yosin@, yoichio@, would you review this please? This CL depends on https://codereview.chromium.org/2697313005 though it seems ...
3 years, 10 months ago
(2017-02-17 08:48:22 UTC)
#6
yosin@, yoichio@, would you review this please?
This CL depends on https://codereview.chromium.org/2697313005 though it seems
|git cl upload| failed to register dependency.
tkent
Description was changed from ========== selection: Align collapse-NN.html and extend-NN.html to the latest draft. https://www.w3.org/TR/selection-api/#dom-selection-collapse ...
3 years, 10 months ago
(2017-02-17 09:00:10 UTC)
#7
Description was changed from
==========
selection: Align collapse-NN.html and extend-NN.html to the latest draft.
https://www.w3.org/TR/selection-api/#dom-selection-collapse
> 3. If node's root is not the document associated with the context object,
> abort these steps.
https://www.w3.org/TR/selection-api/#dom-selection-extend
> 1. If node's root is not the document associated with the context object,
> abort these steps.
Also, this CL updates Blink's extend() implementation so that the root check is
done at the beginning of the function.
This CL fixes 4,259 tests in wpt/selection/.
BUG=683066
==========
to
==========
selection: Align collapse-NN.html and extend-NN.html to the latest draft.
https://www.w3.org/TR/selection-api/#dom-selection-collapse
> 3. If node's root is not the document associated with the context object,
> abort these steps.
https://www.w3.org/TR/selection-api/#dom-selection-extend
> 1. If node's root is not the document associated with the context object,
> abort these steps.
Also, this CL updates Blink's extend() implementation so that the root check is
done at the beginning of the function.
This CL fixes 4,259 tests in web-platform-tests/selection/.
BUG=683066
==========
yosin_UTC9
lgtm
3 years, 10 months ago
(2017-02-17 09:17:35 UTC)
#8
lgtm
tkent
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
3 years, 10 months ago
(2017-02-17 10:45:07 UTC)
#9
Description was changed from ========== selection: Align collapse-NN.html and extend-NN.html to the latest draft. https://www.w3.org/TR/selection-api/#dom-selection-collapse ...
3 years, 10 months ago
(2017-02-17 14:15:17 UTC)
#14
Issue 2698413002: selection: Align collapse-NN.html and extend-NN.html to the latest draft.
(Closed)
Created 3 years, 10 months ago by tkent
Modified 3 years, 10 months ago
Reviewers: yosin_UTC9, yoichio
Base URL:
Comments: 0