Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2698273002: Select-to-speak: Stop speech when tapping Search or Control (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months ago by dmazzoni
Modified:
7 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Select-to-speak: Stop speech when tapping Search or Control BUG=676448 Review-Url: https://codereview.chromium.org/2698273002 Cr-Commit-Position: refs/heads/master@{#451242} Committed: https://chromium.googlesource.com/chromium/src/+/7c8f809603d5e4c7eda82658f5399d8ccc24c3fc

Patch Set 1 #

Total comments: 6

Patch Set 2 : Trigger on tap and release of Search or Control #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -4 lines) Patch
M chrome/browser/chromeos/accessibility/select_to_speak_event_handler.h View 1 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc View 1 2 chunks +29 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/select_to_speak_event_handler_unittest.cc View 1 3 chunks +37 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/accessibility/speech_monitor.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/speech_monitor.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 chunks +4 lines, -2 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 21 (13 generated)
dmazzoni
7 months ago (2017-02-16 16:59:15 UTC) #2
David Tseng
https://codereview.chromium.org/2698273002/diff/1/chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc File chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc (right): https://codereview.chromium.org/2698273002/diff/1/chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc#newcode31 chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc:31: // Stop speech whenever any modifier key is pressed. ...
7 months ago (2017-02-16 17:18:57 UTC) #5
dmazzoni
https://codereview.chromium.org/2698273002/diff/1/chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc File chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc (right): https://codereview.chromium.org/2698273002/diff/1/chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc#newcode31 chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc:31: // Stop speech whenever any modifier key is pressed. ...
7 months ago (2017-02-16 17:38:31 UTC) #6
David Tseng
https://codereview.chromium.org/2698273002/diff/1/chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc File chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc (right): https://codereview.chromium.org/2698273002/diff/1/chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc#newcode31 chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc:31: // Stop speech whenever any modifier key is pressed. ...
7 months ago (2017-02-16 18:40:45 UTC) #9
dmazzoni
https://codereview.chromium.org/2698273002/diff/1/chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc File chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc (right): https://codereview.chromium.org/2698273002/diff/1/chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc#newcode31 chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc:31: // Stop speech whenever any modifier key is pressed. ...
7 months ago (2017-02-16 19:55:55 UTC) #10
David Tseng
lgtm
7 months ago (2017-02-16 22:35:47 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698273002/20001
7 months ago (2017-02-17 05:36:21 UTC) #18
commit-bot: I haz the power
7 months ago (2017-02-17 06:18:50 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7c8f809603d5e4c7eda82658f539...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b