Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc

Issue 2698273002: Select-to-speak: Stop speech when tapping Search or Control (Closed)
Patch Set: Trigger on tap and release of Search or Control Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc
diff --git a/chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc b/chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc
index 27bab6298d4cd19d80076ce00ed709e2fbc050f1..62ddc312c419c0806e3160f3ac60ede15079ff95 100644
--- a/chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc
+++ b/chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc
@@ -5,7 +5,9 @@
#include "chrome/browser/chromeos/accessibility/select_to_speak_event_handler.h"
#include "ash/shell.h"
+#include "chrome/browser/speech/tts_controller.h"
#include "chrome/browser/ui/aura/accessibility/automation_manager_aura.h"
+#include "content/public/browser/browser_thread.h"
#include "ui/aura/window.h"
#include "ui/display/display.h"
#include "ui/events/event.h"
@@ -26,7 +28,33 @@ SelectToSpeakEventHandler::~SelectToSpeakEventHandler() {
}
void SelectToSpeakEventHandler::OnKeyEvent(ui::KeyEvent* event) {
- if (event->key_code() == ui::VKEY_LWIN) {
+ // We can only call TtsController on the UI thread, make sure we
+ // don't ever try to run this code on some other thread.
+ CHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+
+ ui::KeyboardCode key_code = event->key_code();
+
+ // Stop speech when the user taps and releases Control or Search
+ // without pressing any other keys along the way.
+ if (state_ != MOUSE_RELEASED && event->type() == ui::ET_KEY_RELEASED &&
+ (key_code == ui::VKEY_CONTROL || key_code == ui::VKEY_LWIN) &&
+ keys_pressed_together_.find(key_code) != keys_pressed_together_.end() &&
+ keys_pressed_together_.size() == 1) {
+ TtsController::GetInstance()->Stop();
+ }
+
+ // Update keys_currently_down_ and keys_pressed_together_.
+ if (event->type() == ui::ET_KEY_PRESSED) {
+ keys_currently_down_.insert(key_code);
+ keys_pressed_together_.insert(key_code);
+ } else if (event->type() == ui::ET_KEY_RELEASED) {
+ keys_currently_down_.erase(key_code);
+ if (keys_currently_down_.empty())
+ keys_pressed_together_.clear();
+ }
+
+ // Update the state when pressing and releasing the Search key (VKEY_LWIN).
+ if (key_code == ui::VKEY_LWIN) {
if (event->type() == ui::ET_KEY_PRESSED && state_ == INACTIVE) {
state_ = SEARCH_DOWN;
} else if (event->type() == ui::ET_KEY_RELEASED) {

Powered by Google App Engine
This is Rietveld 408576698