Port device_generic_sensor to be hosted in Device Service.

Port device_generic_sensor to be hosted in Device Service.

Generic_sensor is currently hosted in RenderFrameHostImpl, this CL move
it to be hosted in Device Service.

The exsiting dependencies from //content/ to //device/generic_sensors are:
1) Generic_sensor_browsertest. I will replace browsertest by a device service
   test in next CL.
2) JNI registry and APK packaging. It is easy to remove those deps when moving
   //device/generic_sensor files into //service/device.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
BUG=689383
Review-Url: https://codereview.chromium.org/2698083007
Cr-Commit-Position: refs/heads/master@{#463934}
Committed: https://chromium.googlesource.com/chromium/src/+/a91facddec70d3f7bd95075eb9f15fa892572d18

[ke.he, 2017-02-17 15:10:04]

Description was changed from

==========
Port device_generic_sensor to be hosted in Device Service.
==========

to

==========
Port device_generic_sensor to be hosted in Device Service.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[ke.he, 2017-02-17 15:14:10]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 15:14:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 16:30:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 16:30:44]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ke.he, 2017-02-18 00:53:29]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-18 00:54:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 02:56:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 02:56:56]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_site_isolation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[ke.he, 2017-03-23 08:56:55]

Patchset #2 (id:20001) has been deleted

[ke.he, 2017-03-23 08:58:39]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 08:58:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 10:35:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 10:35:22]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ke.he, 2017-03-24 09:03:35]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 09:03:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 09:11:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 09:11:06]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[ke.he, 2017-03-24 09:26:17]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 09:26:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 09:34:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 09:34:03]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[ke.he, 2017-03-24 09:44:43]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 09:44:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ke.he, 2017-03-24 09:48:53]

Description was changed from

==========
Port device_generic_sensor to be hosted in Device Service.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Port device_generic_sensor to be hosted in Device Service.

Generic_sensor is currently hosted in RenderFrameHostImpl, this CL move
it to be hosted in Device Service.

The exsiting dependencies from //content/ to //device/generic_sensors are:
1) Generic_sensor_browsertest. I will replace browsertest by a device service
   test in next CL.
2) JNI registry and APK packaging. It is easy to remove those deps when moving
   //device/generic_sensor files into //service/device.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
BUG=689383
==========

[commit-bot: I haz the power, 2017-03-24 09:52:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 09:52:03]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[ke.he, 2017-03-27 05:43:53]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 05:44:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 06:43:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 06:43:06]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ke.he, 2017-03-27 07:27:04]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 07:27:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 08:16:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 08:17:00]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ke.he, 2017-03-27 10:06:59]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 10:07:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 14:16:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 14:16:19]

Dry run: This issue passed the CQ dry run.

[ke.he, 2017-03-27 14:39:14]

ke.he@intel.com changed reviewers:
+ blundell@chromium.org

[ke.he, 2017-03-27 14:39:16]

Hi, Colin, PTAL, Thanks:)

[blundell, 2017-03-27 14:56:53]

Awesome!

https://codereview.chromium.org/2698083007/diff/120001/services/device/device...
File services/device/device_service.cc (right):

https://codereview.chromium.org/2698083007/diff/120001/services/device/device...
services/device/device_service.cc:98:
registry->AddInterface<mojom::SensorProvider>(this);
We should preserve the check about the feature being enabled, right?

[ke.he, 2017-03-28 05:41:11]

https://codereview.chromium.org/2698083007/diff/120001/services/device/device...
File services/device/device_service.cc (right):

https://codereview.chromium.org/2698083007/diff/120001/services/device/device...
services/device/device_service.cc:98:
registry->AddInterface<mojom::SensorProvider>(this);
On 2017/03/27 14:56:52, blundell wrote:
> We should preserve the check about the feature being enabled, right?
The check code is: "if (base::FeatureList::IsEnabled(features::kGenericSensor))"
The features::kGenericSensor is defined in
//content/public/common/content_features.cc.

I feel we cannot add deps from //service to //content/public/, right? But I find
there is already existed deps from //service to //content/public.(in
service/navigation).

If above deps is allowed, just need to add the
"if (base::FeatureList::IsEnabled(features::kGenericSensor))" here.
Else, my plan is to create a new file services_device_features.cc in
//service/device/public/cpp, and move the definition of features::kGenericSensor
into it. Any comments? thanks!

[blundell, 2017-03-28 07:03:52]

https://codereview.chromium.org/2698083007/diff/120001/services/device/device...
File services/device/device_service.cc (right):

https://codereview.chromium.org/2698083007/diff/120001/services/device/device...
services/device/device_service.cc:98:
registry->AddInterface<mojom::SensorProvider>(this);
On 2017/03/28 05:41:11, ke.he wrote:
> On 2017/03/27 14:56:52, blundell wrote:
> > We should preserve the check about the feature being enabled, right?
> The check code is: "if
(base::FeatureList::IsEnabled(features::kGenericSensor))"
> The features::kGenericSensor is defined in
> //content/public/common/content_features.cc.
> 
> I feel we cannot add deps from //service to //content/public/, right? But I
find
> there is already existed deps from //service to //content/public.(in
> service/navigation).
> 
> If above deps is allowed, just need to add the
> "if (base::FeatureList::IsEnabled(features::kGenericSensor))" here.
> Else, my plan is to create a new file services_device_features.cc in
> //service/device/public/cpp, and move the definition of
features::kGenericSensor
> into it. Any comments? thanks!

Ah, great point! You are correct that a dep from //services/foo to //content is
in general no good (//services/navigation is essentially a sketch of what a
navigation service could look like). Your plan to do the move sounds perfect.

[ke.he, 2017-03-28 13:12:29]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 13:12:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 13:15:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 13:15:54]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[ke.he, 2017-03-28 14:05:08]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 14:05:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 14:15:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 14:15:58]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[ke.he, 2017-03-29 03:07:42]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 03:08:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 03:13:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 03:13:34]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[ke.he, 2017-03-29 03:17:35]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 03:18:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 05:19:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 05:19:14]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)

[ke.he, 2017-03-29 05:48:32]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 05:49:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 06:33:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 06:33:54]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[ke.he, 2017-03-29 09:08:49]

Hi, Colin, PTAL, Thanks!

[blundell, 2017-03-29 09:41:59]

lgtm with nits, thanks!

https://codereview.chromium.org/2698083007/diff/220001/services/device/public...
File services/device/public/cpp/BUILD.gn (right):

https://codereview.chromium.org/2698083007/diff/220001/services/device/public...
services/device/public/cpp/BUILD.gn:7: # The definition of features in
device_features.h are moved from
nit: This comment isn't needed.

https://codereview.chromium.org/2698083007/diff/220001/services/device/public...
File services/device/public/cpp/device_features.cc (right):

https://codereview.chromium.org/2698083007/diff/220001/services/device/public...
services/device/public/cpp/device_features.cc:9: const base::Feature
kGenericSensor{"GenericSensor",
nit: Move the documentation as well.

https://codereview.chromium.org/2698083007/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp (right):

https://codereview.chromium.org/2698083007/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp:23:
Platform::current()->connector()->BindInterface(
Just to sanity-check: This feature doesn't have layout tests that mock the impl
in JS?

[ke.he, 2017-03-29 10:05:12]

https://codereview.chromium.org/2698083007/diff/220001/services/device/public...
File services/device/public/cpp/BUILD.gn (right):

https://codereview.chromium.org/2698083007/diff/220001/services/device/public...
services/device/public/cpp/BUILD.gn:7: # The definition of features in
device_features.h are moved from
On 2017/03/29 09:41:59, blundell wrote:
> nit: This comment isn't needed.

Done.

https://codereview.chromium.org/2698083007/diff/220001/services/device/public...
File services/device/public/cpp/device_features.cc (right):

https://codereview.chromium.org/2698083007/diff/220001/services/device/public...
services/device/public/cpp/device_features.cc:9: const base::Feature
kGenericSensor{"GenericSensor",
On 2017/03/29 09:41:59, blundell wrote:
> nit: Move the documentation as well.

Sorry for this careless:(
Done.

https://codereview.chromium.org/2698083007/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp (right):

https://codereview.chromium.org/2698083007/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp:23:
Platform::current()->connector()->BindInterface(
On 2017/03/29 09:41:59, blundell wrote:
> Just to sanity-check: This feature doesn't have layout tests that mock the
impl
> in JS?

It has, in LayoutTests/sensor/resources/. 
That's why I also changed the LayoutTests/sensor/resources/sensor-helpers.js.

[ke.he, 2017-03-29 10:06:27]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 10:06:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shalamov, 2017-03-29 10:24:07]

alexander.shalamov@intel.com changed reviewers:
+ alexander.shalamov@intel.com

[shalamov, 2017-03-29 10:24:09]

https://codereview.chromium.org/2698083007/diff/240001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp (right):

https://codereview.chromium.org/2698083007/diff/240001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp:23:
Platform::current()->connector()->BindInterface(
I'm concerned about this change, as we should have per frame provider instance
that is responsible for sensor objects management for the given frame. This is a
'MUST' requirement to avoid cross-origin security issues. You can refer to this
design doc for more info
https://docs.google.com/document/d/1Ml65ZdW5AgIsZTszk4mD_ohr40pcrdVFOIf0ZtWxD...

[blundell, 2017-03-29 10:28:07]

https://codereview.chromium.org/2698083007/diff/240001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp (right):

https://codereview.chromium.org/2698083007/diff/240001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp:23:
Platform::current()->connector()->BindInterface(
On 2017/03/29 10:24:08, shalamov wrote:
> I'm concerned about this change, as we should have per frame provider instance
> that is responsible for sensor objects management for the given frame. This is
a
> 'MUST' requirement to avoid cross-origin security issues. You can refer to
this
> design doc for more info
>
https://docs.google.com/document/d/1Ml65ZdW5AgIsZTszk4mD_ohr40pcrdVFOIf0ZtWxD...

Nothing is changing about the granularity of the connection here: the connection
between |m_sensorProvider| and the other side is still per-frame, since the
connection is being made at a per-frame granularity from the client (i.e.,
here). Is there something that I'm missing?

[shalamov, 2017-03-29 11:06:55]

alexander.shalamov@intel.com changed reviewers:
+ reillyg@chromium.org

[shalamov, 2017-03-29 11:06:56]

+reillyg@

lgtm

[commit-bot: I haz the power, 2017-03-29 12:04:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 12:04:40]

Dry run: This issue passed the CQ dry run.

[Reilly Grant (use Gerrit), 2017-03-29 17:33:29]

lgtm

[ke.he, 2017-03-30 02:29:20]

ke.he@intel.com changed reviewers:
+ jam@chromium.org, tsepez@chromium.org

[ke.he, 2017-03-30 02:29:21]

Hi, Jam@, Could you PTAL on //content and //chrome? Thanks.
Hi, Tom, Could you PTAL on *.json files for security review? Thanks!

[ke.he, 2017-03-30 05:54:12]

On 2017/03/30 02:29:21, ke.he wrote:
> Hi, Jam@, Could you PTAL on //content and //chrome? Thanks.
> Hi, Tom, Could you PTAL on *.json files for security review? Thanks!

Hi, Jam@, PTAL on
"third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js" too, Thanks
very much:)

[Tom Sepez, 2017-03-30 16:44:52]

json LGTM

[ke.he, 2017-04-11 12:24:06]

Hi, Jam@, PTAL, thanks!

[jam, 2017-04-11 23:22:45]

On 2017/03/30 05:54:12, ke.he wrote:
> On 2017/03/30 02:29:21, ke.he wrote:
> > Hi, Jam@, Could you PTAL on //content and //chrome? Thanks.
> > Hi, Tom, Could you PTAL on *.json files for security review? Thanks!
> 
> Hi, Jam@, PTAL on
> "third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js" too,
Thanks
> very much:)

really sorry for the delay, I just saw this. please email me directly if I take
long in the future

lgtm for content & chrome. I'm not a webkit owner, so please get an owner review
for all the changes there

[ke.he, 2017-04-12 02:13:10]

On 2017/04/11 23:22:45, jam wrote:
> On 2017/03/30 05:54:12, ke.he wrote:
> > On 2017/03/30 02:29:21, ke.he wrote:
> > > Hi, Jam@, Could you PTAL on //content and //chrome? Thanks.
> > > Hi, Tom, Could you PTAL on *.json files for security review? Thanks!
> > 
> > Hi, Jam@, PTAL on
> > "third_party/WebKit/LayoutTests/sensor/resources/sensor-helpers.js" too,
> Thanks
> > very much:)
> 
> really sorry for the delay, I just saw this. please email me directly if I
take
> long in the future
> 
> lgtm for content & chrome. I'm not a webkit owner, so please get an owner
review
> for all the changes there

Thanks! changes in webkit have been reviewed by shalamov@ who is the owner of
Wekbit generic sensor module.

[ke.he, 2017-04-12 02:13:26]

The CQ bit was checked by ke.he@intel.com

[ke.he, 2017-04-12 02:13:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/2698083007/#ps240001
(title: "Port device_generic_sensor to be hosted in Device Service.")

[commit-bot: I haz the power, 2017-04-12 02:14:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 02:17:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 02:17:24]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[ke.he, 2017-04-12 03:26:20]

The CQ bit was checked by ke.he@intel.com

[ke.he, 2017-04-12 03:26:21]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
reillyg@chromium.org, jam@chromium.org, alexander.shalamov@intel.com,
blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/2698083007/#ps260001
(title: "code rebase")

[commit-bot: I haz the power, 2017-04-12 03:26:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 05:11:56]

CQ is committing da patch.

Bot data: {"patchset_id": 260001, "attempt_start_ts": 1491967580459970,
"parent_rev": "6ede719ec9e4a968c5eedafda3be94c210568d81", "commit_rev":
"a91facddec70d3f7bd95075eb9f15fa892572d18"}

[commit-bot: I haz the power, 2017-04-12 05:12:44]

Description was changed from

==========
Port device_generic_sensor to be hosted in Device Service.

Generic_sensor is currently hosted in RenderFrameHostImpl, this CL move
it to be hosted in Device Service.

The exsiting dependencies from //content/ to //device/generic_sensors are:
1) Generic_sensor_browsertest. I will replace browsertest by a device service
   test in next CL.
2) JNI registry and APK packaging. It is easy to remove those deps when moving
   //device/generic_sensor files into //service/device.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
BUG=689383
==========

to

==========
Port device_generic_sensor to be hosted in Device Service.

Generic_sensor is currently hosted in RenderFrameHostImpl, this CL move
it to be hosted in Device Service.

The exsiting dependencies from //content/ to //device/generic_sensors are:
1) Generic_sensor_browsertest. I will replace browsertest by a device service
   test in next CL.
2) JNI registry and APK packaging. It is easy to remove those deps when moving
   //device/generic_sensor files into //service/device.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
BUG=689383

Review-Url: https://codereview.chromium.org/2698083007
Cr-Commit-Position: refs/heads/master@{#463934}
Committed:
https://chromium.googlesource.com/chromium/src/+/a91facddec70d3f7bd95075eb9f1...
==========

[commit-bot: I haz the power, 2017-04-12 05:12:46]

Committed patchset #13 (id:260001) as
https://chromium.googlesource.com/chromium/src/+/a91facddec70d3f7bd95075eb9f1...