Port device_generic_sensor to be hosted in Device Service.

third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/sensor/SensorProviderProxy.h"
 
 #include "modules/sensor/SensorProxy.h"
 #include "platform/mojo/MojoHelper.h"
-#include "public/platform/InterfaceProvider.h"
 #include "public/platform/Platform.h"
+#include "services/device/public/interfaces/constants.mojom-blink.h"
+#include "services/service_manager/public/cpp/connector.h"
 
 namespace blink {
 
 // SensorProviderProxy
 SensorProviderProxy::SensorProviderProxy(LocalFrame& frame)
     : Supplement<LocalFrame>(frame) {}
 
-void SensorProviderProxy::initializeIfNeeded(LocalFrame* frame) {
+void SensorProviderProxy::initializeIfNeeded() {
   if (isInitialized())
     return;
 
-  frame->interfaceProvider()->getInterface(
-      mojo::MakeRequest(&m_sensorProvider));
+  Platform::current()->connector()->BindInterface(

[blundell, 2017/03/29 09:41:59]

Just to sanity-check: This feature doesn't have layout tests that mock the impl
in JS?

[ke.he, 2017/03/29 10:05:11]

It has, in LayoutTests/sensor/resources/. 
That's why I also changed the LayoutTests/sensor/resources/sensor-helpers.js.

+      device::mojom::blink::kServiceName, mojo::MakeRequest(&m_sensorProvider));
   m_sensorProvider.set_connection_error_handler(convertToBaseCallback(
       WTF::bind(&SensorProviderProxy::onSensorProviderConnectionError,
                 wrapWeakPersistent(this))));
 }
 
 const char* SensorProviderProxy::supplementName() {
   return "SensorProvider";
 }
 
 // static
 SensorProviderProxy* SensorProviderProxy::from(LocalFrame* frame) {
   DCHECK(frame);
   SensorProviderProxy* providerProxy = static_cast<SensorProviderProxy*>(
       Supplement<LocalFrame>::from(*frame, supplementName()));
   if (!providerProxy) {
     providerProxy = new SensorProviderProxy(*frame);
     Supplement<LocalFrame>::provideTo(*frame, supplementName(), providerProxy);
   }
-  providerProxy->initializeIfNeeded(frame);
+  providerProxy->initializeIfNeeded();
   return providerProxy;
 }
 
 SensorProviderProxy::~SensorProviderProxy() {}
 
 DEFINE_TRACE(SensorProviderProxy) {
   visitor->trace(m_sensorProxies);
   Supplement<LocalFrame>::trace(visitor);
 }
 
@@ skipping 19 matching lines @@
   return nullptr;
 }
 
 void SensorProviderProxy::onSensorProviderConnectionError() {
   m_sensorProvider.reset();
   for (SensorProxy* sensor : m_sensorProxies)
     sensor->handleSensorError();
 }
 
 }  // namespace blink