Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2698063002: Mojo C++ bindings: remove usage of AssociatedGroup from media/ (Closed)

Created:
3 years, 10 months ago by yzshen1
Modified:
3 years, 10 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, alokp+watch_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: remove usage of AssociatedGroup from media/ This class is now supposed to be used in bindings-internal code. Users don't have to know about it. BUG=682334 Review-Url: https://codereview.chromium.org/2698063002 Cr-Commit-Position: refs/heads/master@{#450992} Committed: https://chromium.googlesource.com/chromium/src/+/c30e0aff7d3950cd07a42e7bfbc2e05859802d45

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M media/mojo/clients/mojo_audio_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/clients/mojo_renderer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/mojo/clients/mojo_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/media_service_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (11 generated)
yzshen1
Hi, Xiaohan. Would you please take a look? Thanks!
3 years, 10 months ago (2017-02-15 20:22:25 UTC) #5
xhwang
Nice cleanup. Thank you for doing this! LGTM
3 years, 10 months ago (2017-02-16 03:45:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698063002/1
3 years, 10 months ago (2017-02-16 04:10:41 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-16 06:12:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698063002/1
3 years, 10 months ago (2017-02-16 16:45:05 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 16:53:31 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c30e0aff7d3950cd07a42e7bfbc2...

Powered by Google App Engine
This is Rietveld 408576698