Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1230)

Issue 2696233002: Mojo C++ bindings: remove some usage of AssociatedGroup from user code. (Closed)

Created:
3 years, 10 months ago by yzshen1
Modified:
3 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: remove some usage of AssociatedGroup from user code. This class is now supposed to be used in bindings-internal code. Users don't have to know about it. This CL changes mojo/, services/ and ui/ folders. Changes to other folders will be in follow-up CLs. BUG=682334 Review-Url: https://codereview.chromium.org/2696233002 Cr-Commit-Position: refs/heads/master@{#450832} Committed: https://chromium.googlesource.com/chromium/src/+/f3e75ecdc65ff5ee192fba45952848e5b3b6ddac

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -112 lines) Patch
M chrome/browser/ui/ash/cast_config_client_media_router.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_new_window_client.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/media_client.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/associated_binding.h View 2 chunks +7 lines, -11 lines 0 comments Download
M mojo/public/cpp/bindings/associated_interface_ptr.h View 2 chunks +36 lines, -16 lines 0 comments Download
M mojo/public/cpp/bindings/lib/multiplex_router.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/associated_interface_unittest.cc View 12 chunks +13 lines, -29 lines 0 comments Download
M mojo/public/cpp/bindings/tests/bind_task_runner_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/tests/binding_set_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/tests/sync_method_unittest.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M services/service_manager/public/cpp/lib/service_context.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M services/ui/ws/frame_generator.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M services/ui/ws/server_window_delegate.h View 1 chunk +0 lines, -6 lines 0 comments Download
M services/ui/ws/test_server_window_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ws/test_server_window_delegate.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M services/ui/ws/window_server.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ws/window_server.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/ws/window_tree_binding.cc View 1 chunk +1 line, -2 lines 0 comments Download
M services/ui/ws/window_tree_client_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/aura/mus/window_tree_client.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
yzshen1
Hi, Scott. Would you please take a look? Thanks!
3 years, 10 months ago (2017-02-15 18:46:37 UTC) #3
yzshen1
On 2017/02/15 18:46:37, yzshen1 wrote: > Hi, Scott. > > Would you please take a ...
3 years, 10 months ago (2017-02-15 19:26:28 UTC) #10
sky
LGTM
3 years, 10 months ago (2017-02-15 21:14:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2696233002/40001
3 years, 10 months ago (2017-02-15 21:15:31 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 23:23:28 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f3e75ecdc65ff5ee192fba459528...

Powered by Google App Engine
This is Rietveld 408576698