Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2936)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

Issue 2697933002: Remove factory methods from ChromeApplication. (Closed)
Patch Set: Add some comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
index b515d5b43dd1eb38d1a4719b028749a60a9b3813..33ad943315f376169a3a3ccaad86b295bd92a7fa 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
@@ -14,7 +14,7 @@ import org.chromium.base.ApplicationStatus;
import org.chromium.base.Log;
import org.chromium.base.ObserverList.RewindableIterator;
import org.chromium.base.metrics.RecordHistogram;
-import org.chromium.chrome.browser.ChromeApplication;
+import org.chromium.chrome.browser.AppGlobals;
import org.chromium.chrome.browser.fullscreen.FullscreenManager;
import org.chromium.chrome.browser.media.MediaCaptureNotificationService;
import org.chromium.chrome.browser.metrics.UmaSessionStats;
@@ -149,8 +149,7 @@ public class TabWebContentsObserver extends WebContentsObserver {
@Override
public void didFinishLoad(long frameId, String validatedUrl, boolean isMainFrame) {
if (isMainFrame) mTab.didFinishPageLoad();
- PolicyAuditor auditor =
- ((ChromeApplication) mTab.getApplicationContext()).getPolicyAuditor();
+ PolicyAuditor auditor = AppGlobals.get().getPolicyAuditor();
auditor.notifyAuditEvent(
mTab.getApplicationContext(), AuditEvent.OPEN_URL_SUCCESS, validatedUrl, "");
}
@@ -170,8 +169,7 @@ public class TabWebContentsObserver extends WebContentsObserver {
}
private void recordErrorInPolicyAuditor(String failingUrl, String description, int errorCode) {
- PolicyAuditor auditor =
- ((ChromeApplication) mTab.getApplicationContext()).getPolicyAuditor();
+ PolicyAuditor auditor = AppGlobals.get().getPolicyAuditor();
auditor.notifyAuditEvent(mTab.getApplicationContext(), AuditEvent.OPEN_URL_FAILURE,
failingUrl, description);
if (errorCode == BLOCKED_BY_ADMINISTRATOR) {
@@ -283,8 +281,7 @@ public class TabWebContentsObserver extends WebContentsObserver {
mTab.updateFullscreenEnabledState();
- PolicyAuditor auditor =
- ((ChromeApplication) mTab.getApplicationContext()).getPolicyAuditor();
+ PolicyAuditor auditor = AppGlobals.get().getPolicyAuditor();
auditor.notifyCertificateFailure(
PolicyAuditor.nativeGetCertificateFailure(mTab.getWebContents()),
mTab.getApplicationContext());

Powered by Google App Engine
This is Rietveld 408576698