chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java - Issue 2697933002: Remove factory methods from ChromeApplication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

Issue 2697933002: Remove factory methods from ChromeApplication. (Closed)

Patch Set: Add some comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java » ('j') | chrome/android/java_sources.gni » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

index aa830e917095b64efdf05fd5a59366207e97c906..29bb0557042dff751dc07f690e35ee67fbc70498 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

@@ -23,7 +23,7 @@ import org.chromium.base.ObserverList.RewindableIterator;

import org.chromium.base.annotations.CalledByNative;

import org.chromium.blink_public.platform.WebDisplayMode;

import org.chromium.chrome.R;

-import org.chromium.chrome.browser.ChromeApplication;

+import org.chromium.chrome.browser.AppGlobals;

import org.chromium.chrome.browser.RepostFormWarningDialog;

import org.chromium.chrome.browser.document.DocumentUtils;

import org.chromium.chrome.browser.document.DocumentWebContentsDelegate;

@@ -337,8 +337,7 @@ public class TabWebContentsDelegateAndroid extends WebContentsDelegateAndroid {

webContents, mTab.getId(), TabLaunchType.FROM_LONGPRESS_FOREGROUND, url);

boolean success = tabCreator.createsTabsAsynchronously() || createdSuccessfully;

if (success && disposition == WindowOpenDisposition.NEW_POPUP) {

- PolicyAuditor auditor =

- ((ChromeApplication) mTab.getApplicationContext()).getPolicyAuditor();

+ PolicyAuditor auditor = AppGlobals.get().getPolicyAuditor();

auditor.notifyAuditEvent(mTab.getApplicationContext(),

AuditEvent.OPEN_POPUP_URL_SUCCESS, url, "");

}