Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/android/java_sources.gni

Issue 2697933002: Remove factory methods from ChromeApplication. (Closed)
Patch Set: Add some comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java ('K') | « chrome/android/java/templates/BUILD.gn ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java_sources.gni
diff --git a/chrome/android/java_sources.gni b/chrome/android/java_sources.gni
index 87fb0bc30330ea1fa5a22c735043e4c5469ad5cd..23f4e405a2bc84dcb7949c6834ddf3cea1edbfef 100644
--- a/chrome/android/java_sources.gni
+++ b/chrome/android/java_sources.gni
@@ -2,6 +2,8 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+app_globals_file = "java/src/org/chromium/chrome/browser/AppGlobals.java"
agrieve 2017/02/15 19:18:44 nit: I think this would be clearer if you put this
estevenson 2017/02/15 21:46:51 Done.
+
chrome_java_sources = [
"java/src/com/google/android/apps/chrome/appwidget/bookmarks/BookmarkThumbnailWidgetProvider.java",
"java/src/org/chromium/chrome/browser/ActivityTabTaskDescriptionHelper.java",
@@ -23,6 +25,7 @@ chrome_java_sources = [
"java/src/org/chromium/chrome/browser/ChromeBackupAgent.java",
"java/src/org/chromium/chrome/browser/ChromeBackupWatcher.java",
"java/src/org/chromium/chrome/browser/ChromeFeatureList.java",
+ "java/src/org/chromium/chrome/browser/BaseAppGlobals.java",
"java/src/org/chromium/chrome/browser/ChromeHttpAuthHandler.java",
"java/src/org/chromium/chrome/browser/ChromeStrictMode.java",
"java/src/org/chromium/chrome/browser/ChromeSwitches.java",
« chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java ('K') | « chrome/android/java/templates/BUILD.gn ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698