chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java - Issue 2697933002: Remove factory methods from ChromeApplication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java

Issue 2697933002: Remove factory methods from ChromeApplication. (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java b/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java

index 4ae1859eb0cdf3bdaee603d7cd76a305cf3478f2..e94cd94b13aaa247eb0db10e132b4f6b4c15966c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java

@@ -14,7 +14,7 @@ import org.chromium.base.Log;

import org.chromium.base.ThreadUtils;

import org.chromium.base.VisibleForTesting;

import org.chromium.base.metrics.RecordHistogram;

-import org.chromium.chrome.browser.ChromeApplication;

+import org.chromium.chrome.browser.AppHooks;

import org.chromium.chrome.browser.childaccounts.ChildAccountService;

import org.chromium.chrome.browser.identity.UniqueIdentificationGenerator;

import org.chromium.chrome.browser.identity.UniqueIdentificationGeneratorFactory;

@@ -101,8 +101,7 @@ public class SyncController implements ProfileSyncService.SyncStateChangedListen

}

});

- GmsCoreSyncListener gmsCoreSyncListener =

- ((ChromeApplication) context.getApplicationContext()).createGmsCoreSyncListener();

+ GmsCoreSyncListener gmsCoreSyncListener = AppHooks.get().createGmsCoreSyncListener();

if (gmsCoreSyncListener != null) {

mProfileSyncService.addSyncStateChangedListener(gmsCoreSyncListener);

}