chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java - Issue 2697933002: Remove factory methods from ChromeApplication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java

Issue 2697933002: Remove factory methods from ChromeApplication. (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/services/AndroidEduAndChildAccountHelper.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java

index 1d04f639fff14606700d0bf9e1f0fd0801e3a7e8..057b1258cf8238c8888699f3780047bd90877ffd 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java

@@ -35,7 +35,7 @@ import android.util.Pair;

import org.chromium.base.ContextUtils;

import org.chromium.base.metrics.RecordUserAction;

import org.chromium.chrome.R;

-import org.chromium.chrome.browser.ChromeApplication;

+import org.chromium.chrome.browser.AppHooks;

import org.chromium.chrome.browser.childaccounts.ChildAccountService;

import org.chromium.chrome.browser.preferences.ChromeBasePreference;

import org.chromium.chrome.browser.preferences.ManagedPreferenceDelegate;

@@ -304,10 +304,8 @@ public class AccountManagementFragment extends PreferenceFragment

@Override

public boolean onPreferenceClick(Preference preference) {

Activity activity = getActivity();

- ((ChromeApplication) (activity.getApplicationContext()))

- .createGoogleActivityController()

- .openWebAndAppActivitySettings(activity,

- ChromeSigninController.get(activity).getSignedInAccountName());

+ AppHooks.get().createGoogleActivityController().openWebAndAppActivitySettings(

+ activity, ChromeSigninController.get(activity).getSignedInAccountName());

RecordUserAction.record("Signin_AccountSettings_GoogleActivityControlsClicked");

return true;

}