chrome/android/java/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateImpl.java - Issue 2697933002: Remove factory methods from ChromeApplication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateImpl.java

Issue 2697933002: Remove factory methods from ChromeApplication. (Closed)

Patch Set: Rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateImpl.java

index 5446d418a386772319e99308549f4d73728a8522..29a51c02cd82e0097642196f5a612f77917f72f0 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateImpl.java

@@ -7,7 +7,7 @@ package org.chromium.chrome.browser.tab;

import org.chromium.base.VisibleForTesting;

import org.chromium.base.metrics.RecordHistogram;

import org.chromium.chrome.R;

-import org.chromium.chrome.browser.ChromeApplication;

+import org.chromium.chrome.browser.AppHooks;

import org.chromium.chrome.browser.datausage.DataUseTabUIManager;

import org.chromium.chrome.browser.externalnav.ExternalNavigationHandler;

import org.chromium.chrome.browser.externalnav.ExternalNavigationHandler.OverrideUrlLoadingResult;

@@ -51,8 +51,7 @@ public class InterceptNavigationDelegateImpl implements InterceptNavigationDeleg

public InterceptNavigationDelegateImpl(ExternalNavigationHandler externalNavHandler, Tab tab) {

mTab = tab;

mExternalNavHandler = externalNavHandler;

- mAuthenticatorHelper = ((ChromeApplication) mTab.getApplicationContext())

- .createAuthenticatorNavigationInterceptor(mTab);

+ mAuthenticatorHelper = AppHooks.get().createAuthenticatorNavigationInterceptor(mTab);

}

public boolean shouldIgnoreNewTab(String url, boolean incognito) {