MD Settings: Fix subpage URLS for CrOS

MD Settings: Fix subpage URLS for CrOS

This includes some consistency cleanup for url names, and a few
changes to maintain compatability with current/old settings.

BUG=692334
Review-Url: https://codereview.chromium.org/2697723006
Cr-Commit-Position: refs/heads/master@{#451144}
Committed: https://chromium.googlesource.com/chromium/src/+/9197c8376975f8d99d785f2ed0190ccf4758c578

[stevenjb, 2017-02-15 20:41:22]

stevenjb@chromium.org changed reviewers:
+ tommycli@chromium.org

[stevenjb, 2017-02-15 20:41:23]

https://codereview.chromium.org/2697723006/diff/1/chrome/browser/autocomplete...
File chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc (right):

https://codereview.chromium.org/2697723006/diff/1/chrome/browser/autocomplete...
chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc:60: #endif
Blame clang for the formatting ('git cl format').

https://codereview.chromium.org/2697723006/diff/1/chrome/browser/ui/chrome_pa...
File chrome/browser/ui/chrome_pages.cc (left):

https://codereview.chromium.org/2697723006/diff/1/chrome/browser/ui/chrome_pa...
chrome/browser/ui/chrome_pages.cc:271: url = std::string(kChromeUISettingsURL) +
network_page;
I'm not entirely sure what this was intended to do (even though I suspect I
added it), but it isn't necessary (I tested with old and new settings).

[tommycli, 2017-02-15 21:48:13]

looks good thanks lgtm

https://codereview.chromium.org/2697723006/diff/1/chrome/browser/ui/chrome_pa...
File chrome/browser/ui/chrome_pages.cc (left):

https://codereview.chromium.org/2697723006/diff/1/chrome/browser/ui/chrome_pa...
chrome/browser/ui/chrome_pages.cc:271: url = std::string(kChromeUISettingsURL) +
network_page;
On 2017/02/15 20:41:23, stevenjb wrote:
> I'm not entirely sure what this was intended to do (even though I suspect I
> added it), but it isn't necessary (I tested with old and new settings).

Acknowledged.

[stevenjb, 2017-02-15 22:00:50]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-02-15 22:01:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 22:35:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 22:35:03]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[stevenjb, 2017-02-16 18:29:09]

stevenjb@chromium.org changed reviewers:
+ sky@chromium.org

[stevenjb, 2017-02-16 18:29:09]

+sky@ for /chrome/browser owners

[stevenjb, 2017-02-16 18:29:27]

The CQ bit was checked by stevenjb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 18:30:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 19:57:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 19:57:41]

Dry run: This issue passed the CQ dry run.

[sky, 2017-02-16 21:57:41]

LGTM

https://codereview.chromium.org/2697723006/diff/20001/chrome/browser/autocomp...
File chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc (right):

https://codereview.chromium.org/2697723006/diff/20001/chrome/browser/autocomp...
chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc:48:
chrome::kAutofillSubPage,        chrome::kClearBrowserDataSubPage,
Make sure you run git cl format.

[stevenjb, 2017-02-16 22:46:34]

https://codereview.chromium.org/2697723006/diff/20001/chrome/browser/autocomp...
File chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc (right):

https://codereview.chromium.org/2697723006/diff/20001/chrome/browser/autocomp...
chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc:48:
chrome::kAutofillSubPage,        chrome::kClearBrowserDataSubPage,
On 2017/02/16 21:57:41, sky wrote:
> Make sure you run git cl format.

I did. This is clang's fault.

[stevenjb, 2017-02-16 22:46:46]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-02-16 22:46:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2697723006/#ps20001
(title: "Fix browser_tests")

[commit-bot: I haz the power, 2017-02-16 22:48:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 00:00:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487285206782510,
"parent_rev": "d97a44b5bd017589a205d8a7b3f9c68d1b867b4d", "commit_rev":
"9197c8376975f8d99d785f2ed0190ccf4758c578"}

[commit-bot: I haz the power, 2017-02-17 00:01:27]

Description was changed from

==========
MD Settings: Fix subpage URLS for CrOS

This includes some consistency cleanup for url names, and a few
changes to maintain compatability with current/old settings.

BUG=692334
==========

to

==========
MD Settings: Fix subpage URLS for CrOS

This includes some consistency cleanup for url names, and a few
changes to maintain compatability with current/old settings.

BUG=692334

Review-Url: https://codereview.chromium.org/2697723006
Cr-Commit-Position: refs/heads/master@{#451144}
Committed:
https://chromium.googlesource.com/chromium/src/+/9197c8376975f8d99d785f2ed019...
==========

[commit-bot: I haz the power, 2017-02-17 00:01:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9197c8376975f8d99d785f2ed019...