Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: chrome/browser/ui/chrome_pages.cc

Issue 2697723006: MD Settings: Fix subpage URLS for CrOS (Closed)
Patch Set: Fix browser_tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/chrome_pages.cc
diff --git a/chrome/browser/ui/chrome_pages.cc b/chrome/browser/ui/chrome_pages.cc
index 443970abfb188bad281eaeeca273b7bcefbd86c1..6dea3c41769b4b1dc502b62c83baff2c8ca48dca 100644
--- a/chrome/browser/ui/chrome_pages.cc
+++ b/chrome/browser/ui/chrome_pages.cc
@@ -262,16 +262,7 @@ void ShowSlow(Browser* browser) {
}
GURL GetSettingsUrl(const std::string& sub_page) {
- std::string url = std::string(kChromeUISettingsURL) + sub_page;
-#if defined(OS_CHROMEOS)
- if (sub_page.find(kInternetOptionsSubPage, 0) != std::string::npos) {
- std::string::size_type loc = sub_page.find("?", 0);
- std::string network_page =
- loc != std::string::npos ? sub_page.substr(loc) : std::string();
- url = std::string(kChromeUISettingsURL) + network_page;
- }
-#endif
- return GURL(url);
+ return GURL(std::string(kChromeUISettingsURL) + sub_page);
}
bool IsSettingsSubPage(const GURL& url, const std::string& sub_page) {
@@ -323,6 +314,15 @@ void ShowSettingsSubPageForProfile(Profile* profile,
} else if (sub_page == chrome::kDateTimeSubPage) {
sub_page_path = GenerateContentSettingsSearchQueryPath(
IDS_OPTIONS_SETTINGS_SECTION_TITLE_DATETIME);
+ } else if (sub_page == chrome::kStylusSubPage ||
+ sub_page == chrome::kPowerSubPage) {
+ sub_page_path += "-overlay";
+ }
+ } else {
+ if (sub_page == chrome::kPowerSubPage) {
+ // TODO(stevenjbj/derat): Remove this once we have a 'power' subpage,
+ // crbug.com/633455.
+ sub_page_path = "device";
}
}
#endif

Powered by Google App Engine
This is Rietveld 408576698