Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: components/translate/core/browser/translate_ranker_impl.cc

Issue 2697703004: Allow TranslateRanker to override decisions taken by heuristics. (Closed)
Patch Set: Remove unused include. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_ranker_impl.cc
diff --git a/components/translate/core/browser/translate_ranker_impl.cc b/components/translate/core/browser/translate_ranker_impl.cc
index ed4a9b1f2df21957ae73d17330d31d48db803f2c..2ffa6a186b6a0017847eaee7e7cbcd4a37b433e6 100644
--- a/components/translate/core/browser/translate_ranker_impl.cc
+++ b/components/translate/core/browser/translate_ranker_impl.cc
@@ -82,6 +82,9 @@ const base::Feature kTranslateRankerEnforcement{
const base::Feature kTranslateRankerLogging{"TranslateRankerLogging",
base::FEATURE_DISABLED_BY_DEFAULT};
+const base::Feature kTranslateRankerDecisionOverride{
+ "TranslateRankerDecisionOverride", base::FEATURE_DISABLED_BY_DEFAULT};
+
TranslateRankerFeatures::TranslateRankerFeatures() {}
TranslateRankerFeatures::TranslateRankerFeatures(int accepted,
@@ -182,7 +185,13 @@ bool TranslateRankerImpl::IsQueryEnabled() {
}
bool TranslateRankerImpl::IsEnforcementEnabled() {
- return base::FeatureList::IsEnabled(kTranslateRankerEnforcement);
+ return base::FeatureList::IsEnabled(kTranslateRankerEnforcement) ||
+ IsDecisionOverrideEnabled();
+}
+
+bool TranslateRankerImpl::IsDecisionOverrideEnabled() {
+ return base::FeatureList::IsEnabled(
+ translate::kTranslateRankerDecisionOverride);
Alexei Svitkine (slow) 2017/03/06 22:08:20 Nit: Remove translate:: since it's already in this
}
int TranslateRankerImpl::GetModelVersion() const {

Powered by Google App Engine
This is Rietveld 408576698