| Index: components/translate/core/browser/translate_ranker_impl_unittest.cc
|
| diff --git a/components/translate/core/browser/translate_ranker_impl_unittest.cc b/components/translate/core/browser/translate_ranker_impl_unittest.cc
|
| index 41b703043bffc38d3353be48d20c0144abca9714..c3e67d2726ec389c6059d10de7b807376389c712 100644
|
| --- a/components/translate/core/browser/translate_ranker_impl_unittest.cc
|
| +++ b/components/translate/core/browser/translate_ranker_impl_unittest.cc
|
| @@ -32,6 +32,7 @@ namespace {
|
| using translate::kTranslateRankerEnforcement;
|
| using translate::kTranslateRankerLogging;
|
| using translate::kTranslateRankerQuery;
|
| +using translate::kTranslateRankerDecisionOverride;
|
| using translate::TranslateDownloadManager;
|
| using translate::TranslateRankerFeatures;
|
| using translate::TranslatePrefs;
|
| @@ -196,15 +197,17 @@ TEST_F(TranslateRankerImplTest, DisabledByDefault) {
|
| auto ranker = GetRankerForTest(0.5);
|
| EXPECT_FALSE(ranker->IsQueryEnabled());
|
| EXPECT_FALSE(ranker->IsEnforcementEnabled());
|
| + EXPECT_FALSE(ranker->IsDecisionOverrideEnabled());
|
| EXPECT_FALSE(ranker->IsLoggingEnabled());
|
| }
|
|
|
| TEST_F(TranslateRankerImplTest, ExplicitlyDisabled) {
|
| InitFeatures({}, {kTranslateRankerQuery, kTranslateRankerEnforcement,
|
| - kTranslateRankerLogging});
|
| + kTranslateRankerLogging, kTranslateRankerDecisionOverride});
|
| auto ranker = GetRankerForTest(0.5);
|
| EXPECT_FALSE(ranker->IsQueryEnabled());
|
| EXPECT_FALSE(ranker->IsEnforcementEnabled());
|
| + EXPECT_FALSE(ranker->IsDecisionOverrideEnabled());
|
| EXPECT_FALSE(ranker->IsLoggingEnabled());
|
| }
|
|
|
| @@ -213,6 +216,7 @@ TEST_F(TranslateRankerImplTest, EnableQuery) {
|
| auto ranker = GetRankerForTest(0.5);
|
| EXPECT_TRUE(ranker->IsQueryEnabled());
|
| EXPECT_FALSE(ranker->IsEnforcementEnabled());
|
| + EXPECT_FALSE(ranker->IsDecisionOverrideEnabled());
|
| EXPECT_FALSE(ranker->IsLoggingEnabled());
|
| }
|
|
|
| @@ -221,6 +225,7 @@ TEST_F(TranslateRankerImplTest, EnableEnforcement) {
|
| auto ranker = GetRankerForTest(0.5);
|
| EXPECT_FALSE(ranker->IsQueryEnabled());
|
| EXPECT_TRUE(ranker->IsEnforcementEnabled());
|
| + EXPECT_FALSE(ranker->IsDecisionOverrideEnabled());
|
| EXPECT_FALSE(ranker->IsLoggingEnabled());
|
| }
|
|
|
| @@ -229,6 +234,16 @@ TEST_F(TranslateRankerImplTest, EnableQueryAndEnforcement) {
|
| auto ranker = GetRankerForTest(0.5);
|
| EXPECT_TRUE(ranker->IsQueryEnabled());
|
| EXPECT_TRUE(ranker->IsEnforcementEnabled());
|
| + EXPECT_FALSE(ranker->IsDecisionOverrideEnabled());
|
| + EXPECT_FALSE(ranker->IsLoggingEnabled());
|
| +}
|
| +
|
| +TEST_F(TranslateRankerImplTest, EnableDecisionOverride) {
|
| + InitFeatures({kTranslateRankerDecisionOverride}, {});
|
| + auto ranker = GetRankerForTest(0.5);
|
| + EXPECT_FALSE(ranker->IsQueryEnabled());
|
| + EXPECT_TRUE(ranker->IsEnforcementEnabled());
|
| + EXPECT_TRUE(ranker->IsDecisionOverrideEnabled());
|
| EXPECT_FALSE(ranker->IsLoggingEnabled());
|
| }
|
|
|
| @@ -237,16 +252,18 @@ TEST_F(TranslateRankerImplTest, EnableLogging) {
|
| auto ranker = GetRankerForTest(0.5);
|
| EXPECT_FALSE(ranker->IsQueryEnabled());
|
| EXPECT_FALSE(ranker->IsEnforcementEnabled());
|
| + EXPECT_FALSE(ranker->IsDecisionOverrideEnabled());
|
| EXPECT_TRUE(ranker->IsLoggingEnabled());
|
| }
|
|
|
| TEST_F(TranslateRankerImplTest, EnableAll) {
|
| InitFeatures({kTranslateRankerQuery, kTranslateRankerEnforcement,
|
| - kTranslateRankerLogging},
|
| + kTranslateRankerLogging, kTranslateRankerDecisionOverride},
|
| {});
|
| auto ranker = GetRankerForTest(0.5);
|
| EXPECT_TRUE(ranker->IsQueryEnabled());
|
| EXPECT_TRUE(ranker->IsEnforcementEnabled());
|
| + EXPECT_TRUE(ranker->IsDecisionOverrideEnabled());
|
| EXPECT_TRUE(ranker->IsLoggingEnabled());
|
| }
|
|
|
|
|