Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Side by Side Diff: components/translate/core/browser/translate_ranker_impl.cc

Issue 2697703004: Allow TranslateRanker to override decisions taken by heuristics. (Closed)
Patch Set: Remove unused include. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/translate/core/browser/translate_ranker_impl.h" 5 #include "components/translate/core/browser/translate_ranker_impl.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 75
76 const base::Feature kTranslateRankerQuery{"TranslateRankerQuery", 76 const base::Feature kTranslateRankerQuery{"TranslateRankerQuery",
77 base::FEATURE_DISABLED_BY_DEFAULT}; 77 base::FEATURE_DISABLED_BY_DEFAULT};
78 78
79 const base::Feature kTranslateRankerEnforcement{ 79 const base::Feature kTranslateRankerEnforcement{
80 "TranslateRankerEnforcement", base::FEATURE_DISABLED_BY_DEFAULT}; 80 "TranslateRankerEnforcement", base::FEATURE_DISABLED_BY_DEFAULT};
81 81
82 const base::Feature kTranslateRankerLogging{"TranslateRankerLogging", 82 const base::Feature kTranslateRankerLogging{"TranslateRankerLogging",
83 base::FEATURE_DISABLED_BY_DEFAULT}; 83 base::FEATURE_DISABLED_BY_DEFAULT};
84 84
85 const base::Feature kTranslateRankerDecisionOverride{
86 "TranslateRankerDecisionOverride", base::FEATURE_DISABLED_BY_DEFAULT};
87
85 TranslateRankerFeatures::TranslateRankerFeatures() {} 88 TranslateRankerFeatures::TranslateRankerFeatures() {}
86 89
87 TranslateRankerFeatures::TranslateRankerFeatures(int accepted, 90 TranslateRankerFeatures::TranslateRankerFeatures(int accepted,
88 int denied, 91 int denied,
89 int ignored, 92 int ignored,
90 const std::string& src, 93 const std::string& src,
91 const std::string& dst, 94 const std::string& dst,
92 const std::string& cntry, 95 const std::string& cntry,
93 const std::string& locale) 96 const std::string& locale)
94 : accepted_count(accepted), 97 : accepted_count(accepted),
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 178
176 bool TranslateRankerImpl::IsLoggingEnabled() { 179 bool TranslateRankerImpl::IsLoggingEnabled() {
177 return base::FeatureList::IsEnabled(kTranslateRankerLogging); 180 return base::FeatureList::IsEnabled(kTranslateRankerLogging);
178 } 181 }
179 182
180 bool TranslateRankerImpl::IsQueryEnabled() { 183 bool TranslateRankerImpl::IsQueryEnabled() {
181 return base::FeatureList::IsEnabled(kTranslateRankerQuery); 184 return base::FeatureList::IsEnabled(kTranslateRankerQuery);
182 } 185 }
183 186
184 bool TranslateRankerImpl::IsEnforcementEnabled() { 187 bool TranslateRankerImpl::IsEnforcementEnabled() {
185 return base::FeatureList::IsEnabled(kTranslateRankerEnforcement); 188 return base::FeatureList::IsEnabled(kTranslateRankerEnforcement) ||
189 IsDecisionOverrideEnabled();
190 }
191
192 bool TranslateRankerImpl::IsDecisionOverrideEnabled() {
193 return base::FeatureList::IsEnabled(
194 translate::kTranslateRankerDecisionOverride);
Alexei Svitkine (slow) 2017/03/06 22:08:20 Nit: Remove translate:: since it's already in this
186 } 195 }
187 196
188 int TranslateRankerImpl::GetModelVersion() const { 197 int TranslateRankerImpl::GetModelVersion() const {
189 return model_ ? model_->proto().translate().version() : 0; 198 return model_ ? model_->proto().translate().version() : 0;
190 } 199 }
191 200
192 bool TranslateRankerImpl::ShouldOfferTranslation( 201 bool TranslateRankerImpl::ShouldOfferTranslation(
193 const TranslatePrefs& translate_prefs, 202 const TranslatePrefs& translate_prefs,
194 const std::string& src_lang, 203 const std::string& src_lang,
195 const std::string& dst_lang) { 204 const std::string& dst_lang) {
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 model_ = std::move(model); 282 model_ = std::move(model);
274 } 283 }
275 284
276 } // namespace translate 285 } // namespace translate
277 286
278 std::ostream& operator<<(std::ostream& stream, 287 std::ostream& operator<<(std::ostream& stream,
279 const translate::TranslateRankerFeatures& features) { 288 const translate::TranslateRankerFeatures& features) {
280 features.WriteTo(stream); 289 features.WriteTo(stream);
281 return stream; 290 return stream;
282 } 291 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698