Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2697663002: Clean up naming of paint-related identifiers (Closed)

Created:
3 years, 10 months ago by enne (OOO)
Modified:
3 years, 10 months ago
CC:
asanka, chfremer+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dbeam+watch-downloads_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up naming of paint-related identifiers This is a followup to https://codereview.chromium.org/2640983002 that only changed types. This should be purely mechanical. This is the last set of renames. BUG=671433 Review-Url: https://codereview.chromium.org/2697663002 Cr-Commit-Position: refs/heads/master@{#450474} Committed: https://chromium.googlesource.com/chromium/src/+/328308245c390dd1d79844ae2386d38a286eae7d

Patch Set 1 #

Total comments: 2

Patch Set 2 : OOPS #

Patch Set 3 : <_< #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -181 lines) Patch
M apps/ui/views/app_window_frame_view.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/download/download_shelf.cc View 3 chunks +11 lines, -12 lines 0 comments Download
M chrome/browser/extensions/bookmark_app_helper.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_avatar_icon_util.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/extensions/icon_with_badge_image_source.cc View 3 chunks +16 lines, -17 lines 0 comments Download
M chrome/browser/ui/libgtkui/native_theme_gtk2.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/create_application_shortcut_view.cc View 3 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobar_container_view.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/location_bar/background_with_1_px_border.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/status_bubble_views.cc View 2 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 6 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 4 chunks +16 lines, -16 lines 0 comments Download
M content/browser/web_contents/aura/gesture_nav_simple.cc View 1 2 3 2 chunks +11 lines, -11 lines 0 comments Download
M content/browser/web_contents/aura/shadow_layer_delegate.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/capturefromelement/html_video_element_capturer_source.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/sad_plugin.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M media/renderers/skcanvas_video_renderer.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M media/renderers/skcanvas_video_renderer.cc View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
enne (OOO)
This should be purely mechanical (and should be the last of these rename patches, sorry!) ...
3 years, 10 months ago (2017-02-13 19:22:16 UTC) #2
watk
media/ lgtm https://codereview.chromium.org/2697663002/diff/1/media/renderers/skcanvas_video_renderer.h File media/renderers/skcanvas_video_renderer.h (right): https://codereview.chromium.org/2697663002/diff/1/media/renderers/skcanvas_video_renderer.h#newcode48 media/renderers/skcanvas_video_renderer.h:48: SkPaint& flags, Should this be changed to ...
3 years, 10 months ago (2017-02-13 19:38:10 UTC) #5
enne (OOO)
https://codereview.chromium.org/2697663002/diff/1/media/renderers/skcanvas_video_renderer.h File media/renderers/skcanvas_video_renderer.h (right): https://codereview.chromium.org/2697663002/diff/1/media/renderers/skcanvas_video_renderer.h#newcode48 media/renderers/skcanvas_video_renderer.h:48: SkPaint& flags, On 2017/02/13 at 19:38:09, watk wrote: > ...
3 years, 10 months ago (2017-02-13 19:43:30 UTC) #6
sky
LGTM
3 years, 10 months ago (2017-02-13 20:59:03 UTC) #7
benwells
apps/ lgtm
3 years, 10 months ago (2017-02-14 06:44:16 UTC) #8
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-14 12:23:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697663002/40001
3 years, 10 months ago (2017-02-14 17:26:02 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/38621) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 10 months ago (2017-02-14 17:29:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2697663002/60001
3 years, 10 months ago (2017-02-14 19:11:16 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 21:13:06 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/328308245c390dd1d79844ae2386...

Powered by Google App Engine
This is Rietveld 408576698