Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2697513009: Enable forced prerenders on wifi (Closed)

Created:
3 years, 10 months ago by droger
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Enable forced prerenders on wifi Forced prerenders were only enabled on cellular connections, which was causing NoStatePrefetch to be triggered on wifi instead. Forced prerenders are actually intended to work on all connection types. This CL changes this behavior and also renames the functions to remove the references to cellular networks. external_prerender_handler_android.cc has the only behavior change. Changes in other files are only renaming and formatting. BUG=692548 Review-Url: https://codereview.chromium.org/2690393004 Cr-Commit-Position: refs/heads/master@{#450740} (cherry picked from commit 015400e5f61ea871e81cae45fc648df19a50eee1) Review-Url: https://codereview.chromium.org/2697513009 . Cr-Commit-Position: refs/branch-heads/2987@{#548} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/4a63d34db964df3cb96d82a889c47c608a6c734a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -69 lines) Patch
M chrome/browser/prerender/external_prerender_handler_android.h View 1 chunk +12 lines, -11 lines 0 comments Download
M chrome/browser/prerender/external_prerender_handler_android.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/prerender/prerender_histograms.cc View 2 chunks +35 lines, -35 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 4 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/prerender/prerender_origin.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_unittest.cc View 3 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
droger
3 years, 10 months ago (2017-02-16 13:00:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4a63d34db964df3cb96d82a889c47c608a6c734a.

Powered by Google App Engine
This is Rietveld 408576698