Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2690393004: Enable forced prerenders on wifi (Closed)

Created:
3 years, 10 months ago by droger
Modified:
3 years, 10 months ago
Reviewers:
Benoit L
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable forced prerenders on wifi Forced prerenders were only enabled on cellular connections, which was causing NoStatePrefetch to be triggered on wifi instead. Forced prerenders are actually intended to work on all connection types. This CL changes this behavior and also renames the functions to remove the references to cellular networks. external_prerender_handler_android.cc has the only behavior change. Changes in other files are only renaming and formatting. BUG=692548 Review-Url: https://codereview.chromium.org/2690393004 Cr-Commit-Position: refs/heads/master@{#450740} Committed: https://chromium.googlesource.com/chromium/src/+/015400e5f61ea871e81cae45fc648df19a50eee1

Patch Set 1 #

Patch Set 2 : rename nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -69 lines) Patch
M chrome/browser/prerender/external_prerender_handler_android.h View 1 chunk +12 lines, -11 lines 0 comments Download
M chrome/browser/prerender/external_prerender_handler_android.cc View 1 4 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/prerender/prerender_histograms.cc View 2 chunks +35 lines, -35 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 4 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/prerender/prerender_origin.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_unittest.cc View 1 3 chunks +5 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (11 generated)
droger
3 years, 10 months ago (2017-02-15 16:49:27 UTC) #9
Benoit L
lgtm
3 years, 10 months ago (2017-02-15 16:54:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690393004/20001
3 years, 10 months ago (2017-02-15 17:22:39 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 17:35:05 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/015400e5f61ea871e81cae45fc64...

Powered by Google App Engine
This is Rietveld 408576698