Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5345)

Unified Diff: chrome/browser/android/contextualsearch/contextual_search_delegate.cc

Issue 2697513005: [TTS] Add server control from a field_trial param. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/contextualsearch/contextual_search_field_trial.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/contextualsearch/contextual_search_delegate.cc
diff --git a/chrome/browser/android/contextualsearch/contextual_search_delegate.cc b/chrome/browser/android/contextualsearch/contextual_search_delegate.cc
index 765b165126a3ba7ff7b7e56d7c259484bfefb09a..ac4e178455ee64326ee6ed8113013a0ee6356451 100644
--- a/chrome/browser/android/contextualsearch/contextual_search_delegate.cc
+++ b/chrome/browser/android/contextualsearch/contextual_search_delegate.cc
@@ -72,8 +72,6 @@ const int kContextualCardsNoIntegration = 0;
const int kContextualCardsBarIntegration = 1;
const int kContextualCardsSingleAction = 2;
-const char kContextualCardsVersionOverride[] = "contextual_cards_version";
-
} // namespace
// URLFetcher ID, only used for tests: we only have one kind of fetcher.
@@ -240,11 +238,8 @@ std::string ContextualSearchDelegate::BuildRequestUrl(
contextual_cards_version = kContextualCardsSingleAction;
}
- if (base::CommandLine::ForCurrentProcess()->HasSwitch(
- kContextualCardsVersionOverride)){
- contextual_cards_version =
- std::stoi(base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
- kContextualCardsVersionOverride), nullptr);
+ if (field_trial_->GetContextualCardsVersion() != 0) {
+ contextual_cards_version = field_trial_->GetContextualCardsVersion();
}
TemplateURLRef::SearchTermsArgs::ContextualSearchParams params(
« no previous file with comments | « no previous file | chrome/browser/android/contextualsearch/contextual_search_field_trial.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698