Improve the resolution of the menu item homescreen launch source metric.

Improve the resolution of the menu item homescreen launch source metric.

This CL deprecates the SOURCE_ADD_TO_HOMESCREEN source for homescreen
launch intents on Android. Three new buckets are added in its place:
SOURCE_ADD_TO_HOMESCREEN_PWA, SOURCE_ADD_TO_HOMESCREEN_STANDALONE, and
SOURCE_ADD_TO_HOMESCREEN_SHORTCUT.

Existing shortcuts are mapped to either the STANDALONE or SHORTCUT
sources, as it is impossible to properly distinguish PWAs from non-PWAs
when added from the menu item prior to this CL. Following this CL, PWAs
added from the menu item are explicitly tagged with
SOURCE_ADD_TO_HOMESCREEN_PWA.

BUG=690266
Review-Url: https://codereview.chromium.org/2697473005
Cr-Commit-Position: refs/heads/master@{#450902}
Committed: https://chromium.googlesource.com/chromium/src/+/de938a8e39930cca0d2a1f8c96f2cdc9b15192de

[dominickn, 2017-02-14 01:49:08]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-14 01:49:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2017-02-14 02:41:14]

dominickn@chromium.org changed reviewers:
+ dfalcantara@chromium.org, pkotwicz@chromium.org, rkaplow@chromium.org

[dominickn, 2017-02-14 02:41:14]

PTAL thanks!

dfalcantara: launch_metrics.cc
pkotwicz: WebAPKs sanity check
rkaplow: histograms

[commit-bot: I haz the power, 2017-02-14 03:45:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 03:45:14]

Dry run: This issue passed the CQ dry run.

[rkaplow, 2017-02-14 03:58:29]

lgtm

https://codereview.chromium.org/2697473005/diff/1/chrome/browser/android/shor...
File chrome/browser/android/shortcut_info.h (right):

https://codereview.chromium.org/2697473005/diff/1/chrome/browser/android/shor...
chrome/browser/android/shortcut_info.h:27: SOURCE_ADD_TO_HOMESCREEN = 1,
may want to change to OURCE_ADD_TO_HOMESCREEN_DEPRECATED

[dominickn, 2017-02-14 04:29:18]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[dominickn, 2017-02-14 04:29:23]

Thanks!

https://codereview.chromium.org/2697473005/diff/1/chrome/browser/android/shor...
File chrome/browser/android/shortcut_info.h (right):

https://codereview.chromium.org/2697473005/diff/1/chrome/browser/android/shor...
chrome/browser/android/shortcut_info.h:27: SOURCE_ADD_TO_HOMESCREEN = 1,
On 2017/02/14 03:58:29, rkaplow wrote:
> may want to change to OURCE_ADD_TO_HOMESCREEN_DEPRECATED

Good thought, done.

[commit-bot: I haz the power, 2017-02-14 04:30:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 05:54:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 05:54:51]

Dry run: This issue passed the CQ dry run.

[gone, 2017-02-14 19:44:51]

lgtm

https://codereview.chromium.org/2697473005/diff/20001/chrome/browser/android/...
File chrome/browser/android/metrics/launch_metrics.cc (right):

https://codereview.chromium.org/2697473005/diff/20001/chrome/browser/android/...
chrome/browser/android/metrics/launch_metrics.cc:98: case
ShortcutInfo::SOURCE_COUNT:
Should SOURCE_COUNT just fall into default:?

[pkotwicz, 2017-02-14 19:47:11]

https://codereview.chromium.org/2697473005/diff/20001/chrome/browser/android/...
File chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc (right):

https://codereview.chromium.org/2697473005/diff/20001/chrome/browser/android/...
chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc:124:
shortcut_info_.display = blink::WebDisplayModeStandalone;
Nit: Can you please set the source explicitly here?

[dominickn, 2017-02-14 23:02:04]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[dominickn, 2017-02-14 23:02:14]

Thanks!

https://codereview.chromium.org/2697473005/diff/20001/chrome/browser/android/...
File chrome/browser/android/metrics/launch_metrics.cc (right):

https://codereview.chromium.org/2697473005/diff/20001/chrome/browser/android/...
chrome/browser/android/metrics/launch_metrics.cc:98: case
ShortcutInfo::SOURCE_COUNT:
On 2017/02/14 19:44:51, dfalcantara (load balance plz) wrote:
> Should SOURCE_COUNT just fall into default:?

I didn't want to have a default case to ensure that any new additions had to be
explicitly accounted for.

https://codereview.chromium.org/2697473005/diff/20001/chrome/browser/android/...
File chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc (right):

https://codereview.chromium.org/2697473005/diff/20001/chrome/browser/android/...
chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc:124:
shortcut_info_.display = blink::WebDisplayModeStandalone;
On 2017/02/14 19:47:11, pkotwicz wrote:
> Nit: Can you please set the source explicitly here?

Good catch, done.

[commit-bot: I haz the power, 2017-02-14 23:03:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 01:30:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 01:30:57]

Dry run: This issue passed the CQ dry run.

[dominickn, 2017-02-15 05:46:38]

(FYI Peter: I'll wait for you to lg as well before landing)

[pkotwicz, 2017-02-16 04:19:32]

LGTM.

Thank you for adding the metric. It will be useful in determining how many
people install WebAPKs vs classic webapps for WebAPK compatible sites

[dominickn, 2017-02-16 04:21:57]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2017-02-16 04:21:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
rkaplow@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2697473005/#ps40001
(title: "Nits")

[commit-bot: I haz the power, 2017-02-16 04:22:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 05:25:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 05:25:42]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dominickn, 2017-02-16 05:38:41]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2017-02-16 05:39:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 06:25:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 06:25:25]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[Matt Giuca, 2017-02-16 06:27:54]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2017-02-16 06:28:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 08:33:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 08:33:20]

Exceeded global retry quota

[dominickn, 2017-02-16 08:38:04]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2017-02-16 08:38:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 08:51:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487234284779170,
"parent_rev": "c129fcf7b932d95939244304d7e6db825c65117b", "commit_rev":
"de938a8e39930cca0d2a1f8c96f2cdc9b15192de"}

[commit-bot: I haz the power, 2017-02-16 08:51:52]

Description was changed from

==========
Improve the resolution of the menu item homescreen launch source metric.

This CL deprecates the SOURCE_ADD_TO_HOMESCREEN source for homescreen
launch intents on Android. Three new buckets are added in its place:
SOURCE_ADD_TO_HOMESCREEN_PWA, SOURCE_ADD_TO_HOMESCREEN_STANDALONE, and
SOURCE_ADD_TO_HOMESCREEN_SHORTCUT.

Existing shortcuts are mapped to either the STANDALONE or SHORTCUT
sources, as it is impossible to properly distinguish PWAs from non-PWAs
when added from the menu item prior to this CL. Following this CL, PWAs
added from the menu item are explicitly tagged with
SOURCE_ADD_TO_HOMESCREEN_PWA.

BUG=690266
==========

to

==========
Improve the resolution of the menu item homescreen launch source metric.

This CL deprecates the SOURCE_ADD_TO_HOMESCREEN source for homescreen
launch intents on Android. Three new buckets are added in its place:
SOURCE_ADD_TO_HOMESCREEN_PWA, SOURCE_ADD_TO_HOMESCREEN_STANDALONE, and
SOURCE_ADD_TO_HOMESCREEN_SHORTCUT.

Existing shortcuts are mapped to either the STANDALONE or SHORTCUT
sources, as it is impossible to properly distinguish PWAs from non-PWAs
when added from the menu item prior to this CL. Following this CL, PWAs
added from the menu item are explicitly tagged with
SOURCE_ADD_TO_HOMESCREEN_PWA.

BUG=690266

Review-Url: https://codereview.chromium.org/2697473005
Cr-Commit-Position: refs/heads/master@{#450902}
Committed:
https://chromium.googlesource.com/chromium/src/+/de938a8e39930cca0d2a1f8c96f2...
==========

[commit-bot: I haz the power, 2017-02-16 08:51:54]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/de938a8e39930cca0d2a1f8c96f2...