tools/metrics/histograms/histograms.xml - Issue 2697473005: Improve the resolution of the menu item homescreen launch source metric.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2697473005: Improve the resolution of the menu item homescreen launch source metric. (Closed)

Patch Set: Nits Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index f6a3aa9a7c846f867e1938c5f5fa3dfc50f86021..124a37f0d9dd62755fb5afffeff372bdedad6913 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -23423,6 +23423,21 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

Records the source of an Android homescreen launch intent used to launch

Chrome.

+ The Menu item bucket is deprecated as of M57, and will only contain records

+ up until M56.

+ For M57+, the Menu item (standalone) bucket contains all launch intents

+ originating from the add to homescreen menu item that launch to standalone

+ mode and *are not* PWAs. These are sites which do not meet the PWA

+ eligibility criteria, but have an app manifest that specifies either

+ standalone or fullscreen display. This bucket also contains PWA *and*

+ non-PWA intents that were added to the homescreen *prior* to M57, as we

+ cannot distinguish between them after they are added.

+ For M57+, the Menu item (shortcut) bucket contains all launch intents

+ originating from the add to homescreen menu item that launch to a browser

+ tab, regardless of when the intent was added.

</summary>

</histogram>

@@ -96115,11 +96130,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

- <int value="1" label="Menu item"/>

+ <int value="1" label="Menu item (deprecated in M57+)"/>

+ <int value="6" label="Menu item (PWA)"/>

+ <int value="7" label="Menu item (standalone)"/>

+ <int value="8" label="Menu item (shortcut)"/>

</enum>

« no previous file with comments | « chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc ('k') | no next file » | no next file with comments »